[REC] Subtelty rogue shadow dance during GCD recommendation + possible skip_rupture tweak with simms.
IIeTpoc opened this issue ยท 1 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this issue (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Describe the Issue
Addon follows simcraft's recommendion flawlessly but I found out that it recommends to use Shadow Dance before a GCD becomes available which results in loosing 1 effective cast during Shadow Dance window. Here are sims:
- Default T28 Sub rogue sim 16875 DPS
- Shadow dance on GCD sim 16875 DPS
So DPS is the same and makes actually gameplay using addon smoother. As a note i addeduse_off_gcd=0
to all shadow_dance entries in the 2nd sim except for the 1st one in CDs which adresses shuriken_tornado as it is needed to be used off gcd there.
I wanted to add that in default simc profile in line 88actions.cds=shadow_dance,**use_off_gcd=1**,if=!buff.shadow_dance.up&buff.shuriken_tornado.up&buff.shuriken_tornado.remains<=3.5
specifically stated, that Shadow dance should be used off GCD but in all other shadow dance entries GCD is not adressed at all, thus i suspect simc logic is to allign shadow dance use with GCD.
One more thing is about Rupture. Again simc's logic is followed but sometimes addon recommends to refresh Rupture during Shadow dance window where it could fill in 1 more Eviscerate and then reapply rupture outside of Shadow dance with minumum downtime. I provide a snapshot of that situation and also simc reports modeling to not recommend Rupture during stealthed.all
- Default T28 Sub rogue sim 16875 DPS
- Skip rupture during shadow dance 16885 DPS
That is also not a DPS loss compared to default simc priority.
And final sim link modules both skip rupture during stealthed.all
and shadow dance with use_off_gcd=0
mod. LINK 16881 DPS
How to Reproduce
Snapshot (Link)
Raidbots Sim Report (Link)
No response
Additional Information
No response
Contact Information
IIeTpoc#3818 discord ID