Hekili Priority Helper

Hekili Priority Helper

44M Downloads

[BUG] WotLK Classic // Shaman Imbues/Enchants don't show up in the queue (when conditions == True)

arcanechocolate opened this issue ยท 6 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this bug report (above) so that it describes the issue I am reporting.

Describe the Issue

No shaman imbue/enchant spells show up in the queue as recommendations even if the conditions are true. Changing that same priority step to a different spell will show it in the queue.

How to Reproduce

  1. Pick an Enhancement or Elemental Shaman (whilst selecting the corresponding priority list in the addon)
  2. Have weapons equipped with no enchants/imbues active
  3. Addon won't recommend them

Player Information (Link)

https://pastebin.com/YCaE79y7

Error Messages (Link)

https://pastebin.com/vbjra1ai

Additional Information

No response

Contact Information

No response

commented

This should've been a recommendations ticket with a snapshot.

commented

Here are the snapshot instructions from the Recommendations ticket:

Snapshot (Link)

Please supply a Snapshot of the addon's decision-making when you are seeing this issue in-game. This is not a screenshot. To generate a Snapshot, please complete the following steps.

  • Log into your WoW character.
  • Recreate the issue you are reporting (i.e., generate 5 Holy Power).
  • When you see the recommendation you disagree with, press ALT-SHIFT-P to Pause and Snapshot (or use ALT-SHIFT-[ to Snapshot without pausing).
    • You can change these keybindings in /hekili > Toggles if needed.
  • Type /hekili and press Enter.
  • Open the Snapshots section on the left side.
  • Select the display which is showing the recommendation (usually Primary).
  • Select the snapshot number (usually 1, if you took only 1 snapshot).
  • Copy all of the text in the lower box.
  • Paste the text to Pastebin (https://pastebin.com/).
  • Provide the Pastebin link here.

This step is essential, as most issues are related to specific classes, specializations, gear, talent choices, or other game systems.
If you do not provide this information, I cannot triage your problem.

commented

Well, in the meantime I commented lines 1234, 1447, 1526, 1940 and 2351 in ...\Wrath\Shaman.lua corresponding to each of the 5 weapon enchants.

They all share the same code:
usable = function() return ( equipped.mainhand and not mainhand_imbued ) or ( equipped.offhand and not offhand_imbued ), "must have an unimbued weapon" end,

It seems that this is the cause for why the imbues aren't suggested/shown in the queue.
If I broke something I'm sure I'll notice soon enough. For now, the detection seems to be working well enough.

commented

My apologies. I thought of it as a functionality issue instead of a feature since it seems like something is wrong internally (since only specific spells aren't being shown in the queue regardless of their conditionals).

Here's two comparison (A and B) screenshots. One with the default Windfury Weapon spell and the condition as True, and another with Astral Recall and the condition as True.

Thank you. Cheers.

commented

Here's a snapshot.
The issue is right from the get go:

The action (windfury_weapon) is unusable at (0.00 + 0.00) because must have an unimbued weapon.

Here's the snapshot from the modified shaman.lua with the commented lines I mentioned above.
And here's the difference:

  1. windfury_weapon ( precombat - 1 )
    The action (windfury_weapon) is usable at (0.00 + 0.00) with cost of 76 mana.
    • the action is ready before the current recommendation (at +0.00 vs. +10.00).
    • this entry's criteria PASSES: ! mainhand_imbued[false]
      Action chosen: windfury_weapon at 0.00!
commented

This will be fixed later today.