[REC] Night Fae Balance Druid - Convoke the Spirits not being recommended
woefulwabbit opened this issue ยท 3 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this issue (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Describe the Issue
Convoke the Spirits should be recommended whenever CA/Incarnation is up and Convoke is off cooldown. This seems to work fine when Convoke the Spirits is taken as a talent, but does not get recommended at all when Convoke is not taken as a talent but as a Night Fae covenant.
How to Reproduce
- Enter the game as Night Fae Balance Druid
- Remove Convoke the Spirits talent (or change to Incarnation)
- Follow priority
- Note that Convoke the Spirits is never recommended
Taking the Convoke the Spirits talent enables the recommendation.
Snapshot (Link)
Raidbots Sim Report (Link)
No response
Additional Information
Note that in the Snapshot, it says that I have the convoke_the_spirits talent although I did not take the talent - I took Incarnation: Chosen of Elune.
Note also in the Snapshot: 33. convoke_the_spirits ( st - 14 ) - ability unknown
I'm able to fix this with the following changes, however I suspect this may cause Convoke not to work without Night Fae covenant. I'm guessing the copy function does not work
diff --git a/Dragonflight/DruidBalance.lua b/Dragonflight/DruidBalance.lua
index 4a63d4f0..667376e8 100644
--- a/Dragonflight/DruidBalance.lua
+++ b/Dragonflight/DruidBalance.lua
@@ -68,7 +68,7 @@ spec:RegisterTalents( {
balance_of_all_things = { 88214, 394048, 2 }, -- Entering Eclipse increases your critical strike chance with Arcane or Nature spells by 16%, decreasing by 2% every 1 sec.
celestial_alignment = { 88215, 194223, 1 }, -- Celestial bodies align, maintaining both Eclipses and granting 10% haste for 20 sec.
circle_of_life_and_death = { 88227, 391969, 1 }, -- Your damage over time effects deal their damage in 25% less time, and your healing over time effects in 15% less time.
- convoke_the_spirits = { 88206, 391528, 1 }, -- Call upon the Night Fae for an eruption of energy, channeling a rapid flurry of 16 Druid spells and abilities over 4 sec. You will cast Wild Growth, Swiftmend, Moonfire, Wrath, Regrowth, Rejuvenation, Rake, and Thrash on appropriate nearby targets, favoring your current shapeshift form.
+ convoke_the_spirits = { 88206, 323764, 1 }, -- Call upon the Night Fae for an eruption of energy, channeling a rapid flurry of 16 Druid spells and abilities over 4 sec. You will cast Wild Growth, Swiftmend, Moonfire, Wrath, Regrowth, Rejuvenation, Rake, and Thrash on appropriate nearby targets, favoring your current shapeshift form.
cyclone = { 82213, 33786 , 1 }, -- Tosses the enemy target into the air, disorienting them but making them invulnerable for up to 6 sec. Only one target can be affected by your Cyclone at a time.
denizen_of_the_dream = { 88218, 394065, 1 }, -- Your Moonfire and Sunfire have a chance to summon a Faerie Dragon to assist you in battle for 30 sec.
eclipse = { 88223, 79577 , 1 }, -- Casting 2 Starfires empowers Wrath for 15 sec. Casting 2 Wraths empowers Starfire for 15 sec. Eclipse (Solar) Nature spells deal 15% additional damage and Wrath damage is increased by 20%. Eclipse (Lunar) Arcane spells deal 15% additional damage and Starfire critical strike chance is increased by 20%.
@@ -255,11 +255,11 @@ spec:RegisterAuras( {
-- Talent / Covenant (Night Fae): Every 0.25 sec, casting Wild Growth, Swiftmend, Moonfire, Wrath, Regrowth, Rejuvenation, Rake or Thrash on appropriate nearby targets.
-- https://wowhead.com/beta/spell=391528
convoke_the_spirits = {
- id = 391528,
+ copy = 391528,
duration = 4,
tick_time = 0.25,
max_stack = 99,
- copy = 323764
+ id = 323764
},
-- Heals $w1 damage every $t1 seconds.
-- https://wowhead.com/beta/spell=200389
@@ -1682,7 +1682,7 @@ spec:RegisterAbilities( {
-- Talent / Covenant (Night_Fae): Call upon the Night Fae for an eruption of energy, channeling a rapid flurry of $s2 Druid spells and abilities over $d. You will cast $?a24858|a197625[Starsurge, Starfall,]?a768[Ferocious Bite, Shred, Tiger's Fury,]?a5487[Mangle, Ironfur,][Wild Growth, Swiftmend,] Moonfire, Wrath, Regrowth, Rejuvenation, Rake, and Thrash on appropriate nearby targets, favoring your current shapeshift form.
convoke_the_spirits = {
- id = function() return talent.convoke_the_spirits.enabled and 391528 or 323764 end,
+ id = function() return covenant.night_fae and 323764 or talent.convoke_the_spirits.enabled and 391528 end,
cast = function() return 4 * ( legendary.celestial_spirits.enabled and 0.75 or 1 ) * ( talent.ashamanes_guidance.enabled and 0.75 or 1 ) end,
channeled = true,
cooldown = function() return 120 * ( legendary.celestial_spirits.enabled and 0.5 or 1 ) * ( talent.ashamanes_guidance.enabled and 0.5 or 1 ) end,
Contact Information
wabbit#3202
I don't think that's the issue; since you're using a dev copy (i.e., not built beta release), I can't triage this and know if I already addressed this or not.
New paste from v10.1.0-beta2
https://pastebin.com/pvrLvjti
Commit 554af8d has fixed this, thanks