BfA Dots with Casting Time

Question

BfA Dots with Casting Time

thunderchylde opened this issue 6 years ago · 6 comments

thunderchylde commented 6 years ago

I am having an odd™ interaction with a castable dot in the 8.0 code.

I have registered the following Ability:

            -- stellar_flare
            stellar_flare = {
                id = 202347,
                cast = function()
                    return 1.5 * haste
                    end,
                cooldown = 0,
                gcd = 'spell',
                
                spend = -8,
                spendType = 'lunar_power',
                
                startsCombat = true,
                
                hander = function()
                    applyDebuff( 'target', 'stellar_flare' )
                    end,
            },

And I have registered the following Aura:

            -- stellar_flare
            stellar_flare = {
                id = 202347,
                duration = 24,
                max_stacks = 1,
            },

Which is similar to my Sunfire:

            -- sunfire
            sunfire = {
                id = 93402,
                cast = 0,
                cooldown = 0,
                gcd = 'spell',
                
                spend = -3,
                spendType = 'lunar_power',
                
                startsCombat = true,
                
                handler = function()
                    applyDebuff( 'target', 'sunfire' )
                    end,
            },

And

            -- sunfire
            sunfire = {
                id = 164815,
                duration = 18,
                max_stack = 1,
            },

BUT when I include them in an action pack the Sunfire (and the Moonfire spell) both will correctly cast once and then move on in the Action list.

Stellar Flare though will suggest itself indefinitely, seemingly not understanding that the first cast will apply the dot as expected:

build: Working Copy
level: 110
class: DRUID
spec: balance

talents: feral_affinity
    fury_of_elune
    mass_entanglement
    natures_balance
    starlord
    stellar_flare
    tiger_dash

traits: none

sets/legendaries/artifacts: none

gear:     seatreated_armbands=1
    seatreated_boots=1
    sea_sapphire_band=1
    seatreated_mask=1
    beaten_copper_loop=1
    tideshaper_staff=1
    seatreated_trousers=1
    seatreated_belt=1
    seatreated_grips=1
    seatreated_vest=1
    salt_starched_shawl=1
    shaleshell_pendant=1
    oceanographers_weather_log=1
    seatreated_shoulderguards=1
    shimmering_rune=1

New Recommendations for [ Primary ] requested at 00:50:35 ( 22061.65 ).
*** START OF NEW DISPLAY: Primary ***

[ ** ] Checking for recommendation #1 ( time offset: 0.00, remaining GCD: 0.00 ).
[ ** ] lunar_power, 78 / 100
[ ** ] mana, 4000 / 4000
Precombat APL not processed because combat time is 4.27.

Processing default action list [ Balance - default ].
Current recommendation was NO ACTION at +60.00s (clash: 0.00).

[  1]  Checking call_action_list (Balance - default - 1 )...
call_action_list is known and enabled.
There is no criteria for this action list.
Action list (Test) was found.
Current recommendation was NO ACTION at +60.00s (clash: 0.00).

[  2]  Checking starfall (Balance - Test - 1 )...
starfall is known and enabled.
The action (starfall) is usable at (0.00 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria FAILS: talent.soul_of_the_forest.enabled[nil] & buff.starfall.down[true]
The conditions for Test, called from Balance:default:1, would PASS at +0.68.
 - NONE
Recheck #1 ( +0.68 ) NOT MET: talent.soul_of_the_forest.enabled[nil] & buff.starfall.down[true]

[  3]  Checking fury_of_elune (Balance - Test - 2 )...
fury_of_elune is known and enabled.
The action (fury_of_elune) is usable at (0.00 + 55.67).
 - the action is ready before the current recommendation (at +55.67 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +55.67.
 - NONE
 - this entry's criteria FAILS: lunar_power.deficit[21.94] > 40
Rechecking stopped at step #1.  The recheck ( 56.35 ) isn't ready within a reasonable time frame ( 7.5s ).

[  4]  Checking moonfire (Balance - Test - 3 )...
moonfire is known and enabled.
The action (moonfire) is usable at (0.00 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria FAILS: debuff.moonfire.remains[19.14] < 6.6 & lunar_power.deficit[22.00] > 7 & time_to_die[86245.00] > 8
The conditions for Test, called from Balance:default:1, would PASS at +0.68.
 - NONE
Recheck #1 ( +0.68 ) NOT MET: debuff.moonfire.remains[18.45] < 6.6 & lunar_power.deficit[22.00] > 7 & time_to_die[86244.32] > 8

[  5]  Checking sunfire (Balance - Test - 4 )...
sunfire is known and enabled.
The action (sunfire) is usable at (0.00 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria FAILS: debuff.sunfire.remains[16.46] < 5.4 & lunar_power.deficit[22.00] > 7 & time_to_die[86245.00] > 8
The conditions for Test, called from Balance:default:1, would PASS at +0.68.
 - NONE
Recheck #1 ( +0.68 ) NOT MET: debuff.sunfire.remains[15.78] < 5.4 & lunar_power.deficit[22.00] > 7 & time_to_die[86244.32] > 8

[  6]  Checking stellar_flare (Balance - Test - 5 )...
stellar_flare is known and enabled.
The action (stellar_flare) is usable at (0.00 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria PASSES: debuff.stellar_flare.remains[0.00] < 7.2
Action Chosen: stellar_flare at 0.000000!
Returned from list (Test), current recommendation is stellar_flare (+0.00).
Completed default action list [ Balance - default ].
Recommendation is stellar_flare at 0.00 + 0.00.
Prediction engine would recommend stellar_flare at +0.00s.

Recommendation #1 is stellar_flare at 0.00.

[ ** ] Checking for recommendation #2 ( time offset: 1.35, remaining GCD: 0.00 ).
[ ** ] lunar_power, 86 / 100
[ ** ] mana, 4000 / 4000
Precombat APL not processed because combat time is 5.62.

Processing default action list [ Balance - default ].
Current recommendation was NO ACTION at +60.00s (clash: 0.00).

[  1]  Checking call_action_list (Balance - default - 1 )...
call_action_list is known and enabled.
There is no criteria for this action list.
Action list (Test) was found.
Current recommendation was NO ACTION at +60.00s (clash: 0.00).

[  2]  Checking starfall (Balance - Test - 1 )...
starfall is known and enabled.
The action (starfall) is usable at (1.35 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria FAILS: talent.soul_of_the_forest.enabled[nil] & buff.starfall.down[true]
The conditions for Test, called from Balance:default:1, would PASS at +0.68.
 - NONE
Recheck #1 ( +0.68 ) NOT MET: talent.soul_of_the_forest.enabled[nil] & buff.starfall.down[true]

[  3]  Checking fury_of_elune (Balance - Test - 2 )...
fury_of_elune is known and enabled.
The action (fury_of_elune) is usable at (1.35 + 54.32).
 - the action is ready before the current recommendation (at +54.32 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +54.32.
 - NONE
 - this entry's criteria FAILS: lunar_power.deficit[13.94] > 40
Rechecking stopped at step #1.  The recheck ( 55.00 ) isn't ready within a reasonable time frame ( 7.5s ).

[  4]  Checking moonfire (Balance - Test - 3 )...
moonfire is known and enabled.
The action (moonfire) is usable at (1.35 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria FAILS: debuff.moonfire.remains[17.79] < 6.6 & lunar_power.deficit[14.00] > 7 & time_to_die[298.65] > 8
The conditions for Test, called from Balance:default:1, would PASS at +0.68.
 - NONE
Recheck #1 ( +0.68 ) NOT MET: debuff.moonfire.remains[17.10] < 6.6 & lunar_power.deficit[14.00] > 7 & time_to_die[297.97] > 8

[  5]  Checking sunfire (Balance - Test - 4 )...
sunfire is known and enabled.
The action (sunfire) is usable at (1.35 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria FAILS: debuff.sunfire.remains[15.11] < 5.4 & lunar_power.deficit[14.00] > 7 & time_to_die[298.65] > 8
The conditions for Test, called from Balance:default:1, would PASS at +0.68.
 - NONE
Recheck #1 ( +0.68 ) NOT MET: debuff.sunfire.remains[14.43] < 5.4 & lunar_power.deficit[14.00] > 7 & time_to_die[297.97] > 8

[  6]  Checking stellar_flare (Balance - Test - 5 )...
stellar_flare is known and enabled.
The action (stellar_flare) is usable at (1.35 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria PASSES: debuff.stellar_flare.remains[0.00] < 7.2
Action Chosen: stellar_flare at 0.000000!
Returned from list (Test), current recommendation is stellar_flare (+0.00).
Completed default action list [ Balance - default ].
Recommendation is stellar_flare at 1.35 + 0.00.
Prediction engine would recommend stellar_flare at +0.00s.

Recommendation #2 is stellar_flare at 1.35.

[ ** ] Checking for recommendation #3 ( time offset: 2.70, remaining GCD: 0.00 ).
[ ** ] lunar_power, 94 / 100
[ ** ] mana, 4000 / 4000
Precombat APL not processed because combat time is 6.97.

Processing default action list [ Balance - default ].
Current recommendation was NO ACTION at +60.00s (clash: 0.00).

[  1]  Checking call_action_list (Balance - default - 1 )...
call_action_list is known and enabled.
There is no criteria for this action list.
Action list (Test) was found.
Current recommendation was NO ACTION at +60.00s (clash: 0.00).

[  2]  Checking starfall (Balance - Test - 1 )...
starfall is known and enabled.
The action (starfall) is usable at (2.70 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria FAILS: talent.soul_of_the_forest.enabled[nil] & buff.starfall.down[true]
The conditions for Test, called from Balance:default:1, would PASS at +0.68.
 - NONE
Recheck #1 ( +0.68 ) NOT MET: talent.soul_of_the_forest.enabled[nil] & buff.starfall.down[true]

[  3]  Checking fury_of_elune (Balance - Test - 2 )...
fury_of_elune is known and enabled.
The action (fury_of_elune) is usable at (2.70 + 52.97).
 - the action is ready before the current recommendation (at +52.97 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +52.97.
 - NONE
 - this entry's criteria FAILS: lunar_power.deficit[5.94] > 40
Rechecking stopped at step #1.  The recheck ( 53.66 ) isn't ready within a reasonable time frame ( 7.5s ).

[  4]  Checking moonfire (Balance - Test - 3 )...
moonfire is known and enabled.
The action (moonfire) is usable at (2.70 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria FAILS: debuff.moonfire.remains[16.44] < 6.6 & lunar_power.deficit[6.00] > 7 & time_to_die[297.30] > 8
The conditions for Test, called from Balance:default:1, would PASS at +0.68.
 - NONE
Recheck #1 ( +0.68 ) NOT MET: debuff.moonfire.remains[15.76] < 6.6 & lunar_power.deficit[6.00] > 7 & time_to_die[296.62] > 8

[  5]  Checking sunfire (Balance - Test - 4 )...
sunfire is known and enabled.
The action (sunfire) is usable at (2.70 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria FAILS: debuff.sunfire.remains[13.76] < 5.4 & lunar_power.deficit[6.00] > 7 & time_to_die[297.30] > 8
The conditions for Test, called from Balance:default:1, would PASS at +0.68.
 - NONE
Recheck #1 ( +0.68 ) NOT MET: debuff.sunfire.remains[13.08] < 5.4 & lunar_power.deficit[6.00] > 7 & time_to_die[296.62] > 8

[  6]  Checking stellar_flare (Balance - Test - 5 )...
stellar_flare is known and enabled.
The action (stellar_flare) is usable at (2.70 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria PASSES: debuff.stellar_flare.remains[0.00] < 7.2
Action Chosen: stellar_flare at 0.000000!
Returned from list (Test), current recommendation is stellar_flare (+0.00).
Completed default action list [ Balance - default ].
Recommendation is stellar_flare at 2.70 + 0.00.
Prediction engine would recommend stellar_flare at +0.00s.

Recommendation #3 is stellar_flare at 2.70.

[ ** ] Checking for recommendation #4 ( time offset: 4.04, remaining GCD: 0.00 ).
[ ** ] lunar_power, 100 / 100
[ ** ] mana, 4000 / 4000
Precombat APL not processed because combat time is 8.31.

Processing default action list [ Balance - default ].
Current recommendation was NO ACTION at +60.00s (clash: 0.00).

[  1]  Checking call_action_list (Balance - default - 1 )...
call_action_list is known and enabled.
There is no criteria for this action list.
Action list (Test) was found.
Current recommendation was NO ACTION at +60.00s (clash: 0.00).

[  2]  Checking starfall (Balance - Test - 1 )...
starfall is known and enabled.
The action (starfall) is usable at (4.04 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria FAILS: talent.soul_of_the_forest.enabled[nil] & buff.starfall.down[true]
The conditions for Test, called from Balance:default:1, would PASS at +0.68.
 - NONE
Recheck #1 ( +0.68 ) NOT MET: talent.soul_of_the_forest.enabled[nil] & buff.starfall.down[true]

[  3]  Checking fury_of_elune (Balance - Test - 2 )...
fury_of_elune is known and enabled.
The action (fury_of_elune) is usable at (4.04 + 51.62).
 - the action is ready before the current recommendation (at +51.62 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +51.62.
 - NONE
 - this entry's criteria FAILS: lunar_power.deficit[0.00] > 40
Rechecking stopped at step #1.  The recheck ( 52.31 ) isn't ready within a reasonable time frame ( 7.5s ).

[  4]  Checking moonfire (Balance - Test - 3 )...
moonfire is known and enabled.
The action (moonfire) is usable at (4.04 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria FAILS: debuff.moonfire.remains[15.09] < 6.6 & lunar_power.deficit[0.00] > 7 & time_to_die[295.96] > 8
The conditions for Test, called from Balance:default:1, would PASS at +0.68.
 - NONE
Recheck #1 ( +0.68 ) NOT MET: debuff.moonfire.remains[14.41] < 6.6 & lunar_power.deficit[0.00] > 7 & time_to_die[295.27] > 8

[  5]  Checking sunfire (Balance - Test - 4 )...
sunfire is known and enabled.
The action (sunfire) is usable at (4.04 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria FAILS: debuff.sunfire.remains[12.42] < 5.4 & lunar_power.deficit[0.00] > 7 & time_to_die[295.96] > 8
The conditions for Test, called from Balance:default:1, would PASS at +0.68.
 - NONE
Recheck #1 ( +0.68 ) NOT MET: debuff.sunfire.remains[11.73] < 5.4 & lunar_power.deficit[0.00] > 7 & time_to_die[295.27] > 8

[  6]  Checking stellar_flare (Balance - Test - 5 )...
stellar_flare is known and enabled.
The action (stellar_flare) is usable at (4.04 + 0.00).
 - the action is ready before the current recommendation (at +0.00 vs. +60.00).
The conditions for Test, called from Balance:default:1, would PASS at +0.00.
 - NONE
 - this entry's criteria PASSES: debuff.stellar_flare.remains[0.00] < 7.2
Action Chosen: stellar_flare at 0.000000!
Returned from list (Test), current recommendation is stellar_flare (+0.00).
Completed default action list [ Balance - default ].
Recommendation is stellar_flare at 4.04 + 0.00.
Prediction engine would recommend stellar_flare at +0.00s.

Recommendation #4 is stellar_flare at 4.04.

Is this a bug in the code or am I doing something stupid?

thunderchylde · Answer 1 · 2018-06-22T07:54:57.000Z

Just to be clear, as soon as the cast finishes then it all sorts itself out. It just seems that it's unable to project a dot being successful when there is a cast time associated, until that cast is complete.

Hekili · Answer 2 · 2018-06-22T11:53:08.000Z

Could be a bug. Not enough information. I can see that stellar_flare isn't being applied. Do you know for sure that the handler is firing for the stellar_flare ability? Is it possible you have a second ability with that name/ID in your RegisterAbilities list?

Hekili · Answer 3 · 2018-06-22T18:47:01.000Z

You spelled handler wrong, for stellar_flare.

Also, don't specify fake IDs for auras that aren't real -- they get autogenerated IDs now (referring to fury_of_elune_buff).

You'll need to revisit Fury of Elune, since there's nothing that will ever cause that buff to get applied (since it isn't real). You'll need a generate function to sort out when the last cast of Fury of Elune took place, and apply the fake buff accordingly. You can look at feral_spirit in ShamanEnhancement.lua for an example.

thunderchylde · Answer 4 · 2018-06-22T19:08:33.000Z

Thanks for that - I stared at it so long but never noticed.

Also thanks for the advice re: fury of elune - I wasn't sure how that worked anymore.

thunderchylde · Answer 5 · 2018-06-22T18:27:39.000Z

Here's my file as it stands, with a changed extension as it won't let me upload .lua and I've also added it to the .toc file as well but otherwise the code is identical to the Wowinterface download.

The only 3 times the id is used is in the aura, the ability, and the talent.

DruidBalance.txt

thunderchylde · Answer 6 · 2018-06-22T18:30:39.000Z

Here's my Action Pack:

dyZthaGEurQnPcTlPSnub7duz2OmFjPBlP2jQQ9cTBK2VsJcuyyOsJtagSIHlOtbk1XqW5qfrluG(nPwmIwUOxdQ6Paltf8CP6YetvfnzqMovNxs0Pv1Zqv66sCykxcviTzs(Rk9De6ROcLpdkAEcOrIksMgQcJwsyvOcXjrfQUfQO6AOk6EOIYJfADOIW3aLmsapraK5cY)axcbWLdho0iqGxUhiGaVYqbbHweEdMccOwTGGGgZOrbbHwLmTbHNiG9DVJNi4u6oEI8jGNiqOgjtGWGiWI(RPiO7wQmgdbX8DjFdbUXeQ366c7QvxVc5Q0P09MqnsMaTZXDilkvR7wQmgRbPjsrh5FaprGqnsMaHbrqmFxY3qaRqT8gQjkzdsuF89DGBhEWfbw0FnfbQsw5vRUcRqf0r(8INiqOgjtGWGiWI(RPiOwRPQpfeeZ3L8neajKfLQvR1u1NslLA7P9DcCho04Woh3HvOwEd1eLSbjQp((oWTdS254o(xlxxFHEzh42ja0r(8aprGqnsMaHbrGf9xtrqVqvFkiiMVl5BiasilkvRxOQpLwk12t77e4o8SXJDoUdRqT8gQjkzdsuF89DGBhyTZXD8VwUU(c9YoWTtaOJ85jEIaHAKmbcdIal6VMIGUlmMLxfZsbbX8DjFdbqczrPADxymlVkMLslLA7P9DcChy1oGoYNd4jceQrYeiKebw0FnfbDxymlVkMLccI57s(gcGeYIs16UWywEvmlLwk12t77e4oWQDyNJ7WkulVHAIs2Ge1hFFh42Hqa7CCh)RLRRVqVSdC7ea6iFyHNiqOgjtGWGiWI(RPiORzwEjMMxbcI57s(gcilkvRRzwEL6qnrjRfQ36UfHVVdNTdV7CChwHA5nutuYgKO(477a3oe4IoYpa8ebc1izcegebw0FnfbSc1YB3ZhEbbX8DjFdbKfLQXkulVsDOMOK1c1BD3IW33HZ2H3DoUdRqT8gQjkzdsuF89DGBhc8eDKpNeprGqnsMaHbrGf9xtrq3TSxsykiiMVl5Biag7aZi0oCKDGXoSc1YBOMOKTyjtH67Wr3HhC3b27a3o(xlxxFHEzhyVt1Q7WkulVHAIs2Ge1hFFNa3HxEUt1Q7aJDilkv7PrlPM)AAReUt1Q7qwuQwuys3FJDn2dtATq9wjChyVt1Q7aJDilkvR7wY0juReUZXDilkvR7wY0juR7we((obUdV7a7DQwDhYIs16ULmDc1sP2EAFNa3HaxUC5YLl6iFcCXteiuJKjqyqeyr)1ueWkulVDpF4feeZ3L8neqwuQgRqT8k1HAIswluVvc354oWyhYIs10ezW)0RkfkNUYwjCNQv3HSOunIwMVoVA1vyfQ0kH7aB0r(eiGNiqOgjtGWGiiMVl5BiGSOuTUMz5vQd1eLSwOEReIal6VMIGUMz5LyAEfOJ8jCaprGqnsMaHbrGf9xtraRqT8298HxqqmFxY3qazrPASc1YRuhQjkzTq9wjeDKpbEXteiuJKjqyqeyr)1ue01mlVetZRaD0raKOScZXtKpb8ebc1izcegebw0FnfbrJXUw0Fn9Y(UJa239l1QfeCkDhD0rqykrDnP54j6OJGUUKrbbiGS8mNJtrseazUGGdCjeaNZLdC(Hd7qGaNGxUiOhkrKpbUhqGv8k0jc4yvYGIvujdsqaK0Ji4SIVVZ33X2j0IWBWu2rR2XI(RP7W(U33rPZD4uc8p7BOJoIa

Share to