ReAdd Bartender4 keybind support for other bars
Wyste opened this issue ยท 5 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this request and was not able to find one.
- I edited the title of this feature request (above) so that it describes the issue I am reporting.
WoW Version
Retail (Dragonflight)
Feature Request
In Hekili Events.lua, the BT4 keybinding detection logic uses
bindingKeyName = "CLICK BT4Button" .. actionBarButtonId .. ":Click"
but should actually be changed to
bindingKeyName = "CLICK BT4Button" .. actionBarButtonId .. ":Keybind"
to match the proper Binding names within Bartender4. Reference: https://github.com/Nevcairiel/Bartender4/blob/master/Bindings.xml
I've made the change locally to Line 2105 to check (after uncommenting the section)
Line 2105 in 1a1d3ca
and checked in-game and can now see the proper "Shift-2" keybinding (S2 in Hekili) which is located on BT Bonus Actionbar, Button #14 and also BT Bar4 button 38 is showing "Alt-2" keybinding (A2 in Hekili)
Cropped Screenshot: (Hekili in top right of pic, bars near bottom)
Additional Information
You may want to do some additional testing / proofreading, but this seems to be working, at least for me. I'm not 100% if there's any additional impact to BT4 or keybinds for other user addon setups.
Contact Information
Wyste#8631
I saw that you closed this, but one of the challenges here is that BT4 + base UI can be very misleading.
Those buttons showing 1, 2, 3 are BT4Button1, 2, and 3. They don't have a keybind set under Bartender4:
The binding is actually falling back on default action bar bindings:
I'm testing an approach that looks for BT4 bindings first, and falls back on defaults, but the risk is that those buttons show the default UI's keybinds while the addon shows BT4's.
Yeah, I closed it because I'm sifting through the horror that is BT4 keybind support. Still working on it, it'll just be a PR later; assuming you don't get to it first.
OH, I just noticed 2c9f1ba. I'm a little behind, so sorry if the above comment doesn't make sense.
