Hekili Priority Helper

Hekili Priority Helper

46M Downloads

[BUG] Retribution Paladin uses wrong spell ID for Divine Protection

Thordros opened this issue ยท 3 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this bug report (above) so that it describes the issue I am reporting.

Describe the Issue

Since the 10.0.7 revamp Retribution regained Divine Protection as a baseline ability rather than a talent, but it uses a new spell ID: 403876.

Correcting the ID on lines 352, 354, and 1261 of RetributionPaladin.lua fixes the primary issue (not being able to add it to defensive recommendations), but I imagine you'll probably want to actually fix how it's categorized and stuff, too.

How to Reproduce

Adding

actions+=/divine_protection

to the APL produces no output in any recommendation queues.

Player Information (Link)

https://pastebin.com/MqBAtsJg

Error Messages (Link)

Not required.

Additional Information

No response

Contact Information

Thordros#1784

commented
commented

Should've been a recommendations report with a snapshot to show the output, but I'll sort it out.

commented

Thanks; resolved.