Hekili Priority Helper

Hekili Priority Helper

44M Downloads

[REC] Outlaw Rogue, Vanish/Shadowdance recommended while bte is on cooldown

chevyn11 opened this issue ยท 5 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this issue (above) so that it describes the issue I am reporting.
  • I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Describe the Issue

The new outlaw talent Crackshot makes Between the Eyes (BTE) have no cooldown if used from stealth. This means that you ideally want between the eyes to be ready before using a stealth(+subterfuge) ability like vanish or shadowdance.

In the sims, because it plays perfectly it deals with this by not using BTE if vanish/shadowdance are coming up soon. However for an imperfect player it is possible to hit BTE at the wrong time and not have it ready for an upcoming crackshot window. In these cases it is recommended not to use vanish or shadowdance until BTE is ready.

From the rogue discord:
image

Specifies "with BTE ready" in the cooldown priority list:
image

How to Reproduce

  1. Enter the game as an Outlaw Rogue
  2. Build combo points
  3. Use BTE
  4. Follow hekili recommendations until it suggests vanish or shadowdance

Snapshot (Link)

https://pastebin.com/GsNYhGLE

Raidbots Sim Report (Link)

https://www.raidbots.com/simbot/report/osHuP95BQa4T7qYydCQqGX

Additional Information

I have included a raidbots report where I ammended the following condition to prove it will have no effect on sim dps because it already does this but in a roundabout way (not using bte if vanish/dance are coming up).

before:

actions.cds+=/call_action_list,name=stealth_cds,if=!stealthed.all

after:

actions.cds+=/call_action_list,name=stealth_cds,if=!stealthed.all&cooldown.between_the_eyes.ready

Contact Information

chevyn

commented

oh just had a thought, maybe the fix should check for the crackshot talent too...

commented

Looks pretty solid. Have you submitted your changes to SimulationCraft as well?

commented

I've adjusted this to look to see if you even have Crackshot before waiting for BtE, but otherwise, implemented the same safety mechanism.

commented

@Hekili haven't checked it in game yet, but reviewing the change i think you added it to the stealth list instead of the stealth_cds so I'm not sure this will have the same effect. stealth_cds is called from the cds list.

I haven't submitted this to simc as it was a neutral change and only really affects add-ons like this one downstream..

commented

Can confirm this still happens with 1.0.0f

https://pastebin.com/2MXYe2ss