Hekili Priority Helper

Hekili Priority Helper

44M Downloads

[REC] OUTLAW - Roll the Bones being recommend while in stealth window (without the chance of them falling off)

aycheff opened this issue · 5 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this issue (above) so that it describes the issue I am reporting.
  • I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Describe the Issue

When doing the outlaw rotation, hekili is recommending to use roll the bones during crackshot (stealth window). Even when there is enough time within your stealth window to fit another GCD in like Between the Eyes or something and the buff will NOT fall off, it will recommend Roll the Bones even though you can reroll after your stealth window without the buffs falling off.

Here is a screenshot of a scenario. Things happening in this screenshot: I have 2 buffs up from roll the bones with 12 seconds left. The addons is recommending to reroll even though I have 2 seconds left on my subterfuge (stealth window). Unless the buff is going to fall off, you should never reroll inside your stealth windows.

Image 12-8-23 at 9 01 PM

How to Reproduce

  1. Enter combat as outlaw rogue with buffs from roll the bones
  2. Enter your stealth window with RTB off CD.
  3. Addon will occasionally recommend to reroll inside the stealth window even though the buffs would not fall off.

Snapshot (Link)

https://pastebin.com/JTbciUHD

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

commented

I see whats happening, its essentially these points in the RTB priority from the rogue discord and they make up the rtb_reroll variable in the APL:
image
in hekili:
image

You have 2 buffs active and you have loaded dice up (from adrenaline rush). Using rtb here guarantees you 3 rtb buffs (2 from loaded dice + 1 from your t31). I think this has been found by the rogue theorycrafters to be either good or neutral to do even within stealth so the recommendation is correct :D

commented

I see whats happening, its essentially these points in the RTB priority from the rogue discord and they make up the rtb_reroll variable in the APL: image in hekili: image

You have 2 buffs active and you have loaded dice up (from adrenaline rush). Using rtb here guarantees you 3 rtb buffs (2 from loaded dice + 1 from your t31). I think this has been found by the rogue theorycrafters to be either good or neutral to do even within stealth so the recommendation is correct :D

Sure, but you can reroll after and not potentially miss a damage ability in your window. And While yes that’s true, most will recommend not rolling in your stealth window. It’s bad practice. I can make the decision on my own fo course but I use hekili to reduce as much of that as I can.

Is there a way I can edit the hekili APL to instead not recommend rerolling in stealth windows if the buffs won’t drop, and instead reroll before if time left on buffs is <7s and vanish/sd is ready as is general best practice.

commented

Sure, you can add & ! ( buff.subterfuge.up | buff.shadow_dance.up ) to the rtb_reroll variable under the Action Lists tab, so it will look like this:

image

Although I take no responsibility for what other interactions this might cause 😄
The rtb_reroll variable is also used for KIR rules.

commented

It's worth making the same adjustments to your sim profile and testing whether it proves to be more performant. If so, you can ticket SimC to avoid making that refresh and all our tools will be in sync.

edit: I don't see a positive/productive difference -- I made it never reroll in Subterfuge or Shadow Dance.

https://www.raidbots.com/simbot/report/6BKc4EvdbdcG9jphZaW8An/simc

image

commented

I'm going to address this with a user preference option:

image