[11.0.2] Spells Replaced by Hero Talents
MatteoLombardi opened this issue · 28 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this issue (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Describe the Issue
In beta everything seems to work just fine for aug evoker, the main issue I found seems to be Breath of the Eons not stopping being recommended when overwritten by the talent enabling steering. Should be a pretty straight forward fix, can't provide a snapshot right now, but I will once I get home. Just wanted to address it in time for early access (same happens for summon demon for warlock and shadowfiend for voidweaver, but not gonna open 3 issues without snapshots)
How to Reproduce
Enter the game as max level aug evoker with Scalecommander and just play around
Snapshot (Link)
Will provide! (Sorry, terrible reporter)
Raidbots Sim Report (Link)
No response
Additional Information
No response
Contact Information
No response
The new commit fixed aug, so I'm updating the issue with the other cases to help keeping track!
SPriest error with Shadowfiend: https://pastebin.com/9VV59xsu (there's a lot of LUA errors regarding entropic rift, had to cut the logs to fit pastebin's limit)
I'll fix the typo causing those errors you noted. In terms of catching spell replacements for new (hero) talents, the details I'll need to fix them up would be:
- Class / Spec
- (Hero) Talent
- Spell
xshould change to spellywhen (zis talented orzbuff is active, etc.)
Ideally, x and y are the spell IDs on your action bar. You can set up ElvUI to show the spell ID in the tooltip or get another addon that includes spell IDs in tooltips.
I'll fetch them soon :) I'd do the changes myself and open a PR given the time, but giving you the data is prolly faster
Priest/Shadow
Voidweaver
Shadowfiend (34433) should change to Voidwraith (451235) when talented in Voidwraith
@Hekili I understood what the problem with warlock might be, dunno if you need a snapshot or not. The addon gets stuck on the "generic" summon demon spell with affliction, since it's missing the preferred demon option that Destro has. So the primary icon is an empty square with no icon, pause shows it being "Summon demon"
Also:
- Warlock / Affliction
- Hellcaller
- Corruption (172) should change to Wither (445468) when talented in Wither
Just wanted to piggy back off this since Devastation Evoker has the same issue with Deep Breath on Live now, it keeps recommending Deep Breath even after using it when you have Maneuverability.
Class/Spec: Evoker (Devastation)
Hero Talents: Scalecommander
Talent Name: Maneuverability
Deep Breath ID needs to change from 357210 to 433874 when you're playing Scalecommander with Maneuverability.
- Demon Hunter / Both
- Aldrachi-Reaver
- Throw Glaive (185123) should Change to Reaver's Glaive (442294) when talented in Art of the Glaive (every 6 Soul Fragments or after The Hunt is cast)
Class/Spec: Evoker (Augmentation)
Hero Talents: Chronowarden
Talent Name: Chrono Flame
Living Flame (361469) should change to Chrono Flames (431443) when talented into Chrono Flame
Confirmed last night for Warlock.
Affliction when talented into Hellcaller/Wither does not replace corruption neither spell is ever recommended. Didn’t test destruction. But Wither should replace immolate.
Another Ret paladin (@xilostcause) in #3520 notifies the error in this snapshot
Class/Spec: Evoker (Augmentation)
Hero Talents: Scalecommander
Talent Name: Maneuverability
Breath of Eons ID (403631) should change to (unconfirmed) 442204 when you're playing Scalecommander with Maneuverability.
No, I need the snapshot when the recommendations have stopped. The snapshot you provided is recommending Shadowfiend, no?
Nope! 😅
I pressed Voidwraith and then the snapshot key. I'll try again with some screenshots.
Before entering combat:
After pressing Voidwraith:
It looks like it generated two snapshots automatically so maybe I copied a wrong one? Here is both:
I too was about to report the matter with Hammer of light, but decided to look if it had reports already. seem like its just a matter of patience to fix.
Adding on to this, when picking the talent Voidwraith for Voidweaver priest the recommendations completely break.
Mindbender (123040) if specced into it, or Shadowfiend (34433) is being replaced with Voidwraith (451235). Hekili recommends to cast Mindbender, and when it is cast stops recommending most abilities until is off cooldown again.
Mindbender (123040) if specced into it, or Shadowfiend (34433) is being replaced with Voidwraith (451235). Hekili recommends to cast Mindbender, and when it is cast stops recommending most abilities until is off cooldown again.
It would be helpful to provide a snapshot when the recommendations fail.
Pretty much the same snapshot I shared for shadowfiend, just with mindbender. Since Mindbender replaces Shadowfiend, and Voidwraith replaces both, no matter which variant of the pet you have talented, it should become Voidwraith. Since the addon is not recommending Voidwraith but the talented pet, it gets stuck as it used to with Maneuverability and Breath of the Eons for Aug
Mindbender (123040) if specced into it, or Shadowfiend (34433) is being replaced with Voidwraith (451235). Hekili recommends to cast Mindbender, and when it is cast stops recommending most abilities until is off cooldown again.
It would be helpful to provide a snapshot when the recommendations fail.
It's pretty reproducible, here's the snapshot I just got. Simply pulled the mob and cast Voidwraith and it failed over to the scov_prep action list. It also doesn't recognize that Voidwraith is on cooldown so it goes back to recommending Mindbender as soon as the Voidwraith pet has expired, even though it can't be cast yet.
No, I need the snapshot when the recommendations have stopped. The snapshot you provided is recommending Shadowfiend, no?
Deep Breath is being recommended when it's on CD
Evoker / Devastation
Scalecommander, Talent 433871 (Maneuverability)
Deep Breath 357210 should change to Deep Breath 433874 when Maneuverability 433871 is talented
Is this fixed for Aug with the newest update? @MatteoLombardi
Can coroborate Devestation Evoker Scalecommander recomending Deep Breath after it has been used and is on CD.
As Above believe:
Talent 433871 (Maneuverability)
Deep Breath 357210 should change to Deep Breath 433874 when Maneuverability 433871 is talented
will fix issue
I see that it was noted a few months ago and again a couple of weeks ago so just giving it a bump... wither is not replacing corruption as it should. This is as of version 11.0.2-1.0.7
Warlock/Affliction
Hellcaller
corruption->wither
I see that it was noted a few months ago and again a couple of weeks ago so just giving it a bump... wither is not replacing corruption as it should. This is as of version 11.0.2-1.0.7
Warlock/Affliction Hellcaller corruption->wither
Have you made any edits to your APL? Because i have never had this issue.
I see that it was noted a few months ago and again a couple of weeks ago so just giving it a bump... wither is not replacing corruption as it should. This is as of version 11.0.2-1.0.7
Warlock/Affliction Hellcaller corruption->witherHave you made any edits to your APL? Because i have never had this issue.
Not quite clear on what you are asking - I've not changed any of the hekili code.
When the servers come back up I'll disable everything else and dig a bit more.
EDIT: This was user error - sorry folks.