Hekili Priority Helper

Hekili Priority Helper

50M Downloads

[BUG] Spellflash does not display on Dominos action bars beyond 1&2

superwario15 opened this issue ยท 9 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this bug report (above) so that it describes the issue I am reporting.

Describe the Issue

When spellflash is enabled, it displays normally on any abilities that are bound to Dominos action bars 1 or 2, however, if an ability is bound to any bar other than those 2, it does not display.

I have attached images to indicate the issue. The first image image shows my current bindings, and the ability I'm using as the example is Deathmark which is currently bound to Dominos action bar 6.

WoWScrnShot_080824_134906

The next image shows the correct behavior when I just bind Deathmark to Dominos action bar 1

WoWScrnShot_080824_134943

I have confirmed this issue seems to be class-independent and occurs on every character I have.

How to Reproduce

  1. Enter game using Dominos and Hekili addons.
  2. Enable spellflash for Hekili recommendations.
  3. Bind an ability to be recommended on any action bar that is not 1 or 2.
  4. Begin combat rotation.

Player Information (Link)

https://pastebin.com/raZxZUmK

Error Messages (Link)

No error messages.

Additional Information

No response

Contact Information

No response

commented

Do you have SpellFlashCore installed separately from the addon, or are you using the one that's included in it?

commented

I do not have SpellFlash installed separately; I'm just using SpellFlashCore that is included with Hekili.

commented

That explains so much, I was going insane trying to figure out why my so many of my spells refused to flash. Literally all of my non damaging spells are on bar 3 or 4, and they will not flash.

image

commented

I think I may have found some info that may be of use for solving the issue, bars 3 and onwards have a frame name like so,
image

But bars 1 and 2 have a frame name like so,

image

commented

I can confirm I'm having this issue as well with the most current version of Dominos. I have only Hekili installed with its built in version of Spellflash.

Moreover, I disabled Dominos and Spellflash works with the default blizzard actionbars.

commented

I've not delved into the code of this addon, but if you want to apply custom behavior to action buttons derived from the stock Blizzard templates, I'd do something like this:

-- register known action buttons
for _, button in pairs(ActionBarButtonEventsFrame.frames) do
    registerActionButton(button)
end

-- and watch for any additional action buttons
hooksecurefunc(ActionBarButtonEventsFrame, "RegisterFrame", function(_, button)
    registerActionButton(button)
end)
commented

Hopefully this can be fixed sooner rather than later.

commented

Taking a shot in the dark in 1.0.15 to address this.

commented

*1.0.14 -- this should now be resolved.