[Warrior] Arms Simulation APL fix (by Skyhold Discord)
j-mes opened this issue ยท 10 comments
Describe the Bug/Issue
It is well known that the simulation APL is not correct for Arms Warrior, and a kind person decided to fix it and shared it with the Skyhold discord for Warriors to use on Raidbots.
However, I'd love to see this in Hekili as well, and I tried to convert and it wouldn't work. Apologies in advance if I've missed any documentation/guide for doing this and making it work.
See the pastebin for the fixed SimulationCraft APL. The source from Skyhold Discord (The link only works if you're in that Discord as well).
To Reproduce
- Copied the raw contents of the Pastebin.
- Pasted in a new 'Arms' profile called 'ArmsModified'.
- Loaded it, and it did not display like it would with the normal Arms profile.
Expected behavior
- Copy APL then load in a new profile.
- ๐ New ArmsModified profile to test.
Information asked for (also for TL;DR)
- /hekili > Issue Reporting > Output - PasteBin
- Modified APL from Warrior Discord for Arms - PasteBin
- Source of the modified APL from Warrior Discord - Skyhold
I hope this is enough information for you, and that it won't be discarded ๐ค
P.S. I like the pug in a taco outfit. Very cool ๐
You could probably import this if you remove all the quotation marks, but I'll test it myself.
After importing, you'd need to select the APL in your spec's options.
FWIW, the default Arms APL in the addon is edited since the HAC list isn't useful, IIRC. I'll see what's different between the two.
Are there linked sims showing the better performance?
Woow @Hekili that is such a quick response. I did not expect one tonight but kudos to you.
I've done two sims based on myself for you to look at.
Raidbots without modified APL - 84,939 DPS
Raidbots with modified APL - 87,629 DPS
Would that be based on Executioner's Precision which is not in the game anymore? ๐ค
Can you run a Hectic Add Cleave or add more bosses to your Patchwerk sim?
I thought the fixes were aimed at resolving for multi-target.
But yeah, the five_target priority wouldn't use Mortal Strike without Dreadnaught talented, because of the EP check. I don't know if that's intended or not, since EP isn't available.
Okay! I've normalised it with the same talent/azerite/essence combinations across all 6 sims now.
Patchwerk (1 Boss)
- SimulationCraft APL - 91,453 DPS
- Modified Skyhold APL - 95,176 DPS
Patchwerk (5 Bosses)
- SimulationCraft APL - 154,912 DPS
- Modified Skyhold APL - 155,087 DPS
Hectic Add Cleave
- SimulationCraft APL - 130,416 DPS
- Modified Skyhold APL - 129,976 DPS
๐ค It feels like the differences are mostly single target. The HAC/Patchwerk with 5 bosses seems quite close. Forgive me if I interpreted your Patchwerk x5 wrong, unless you wanted me to run the sims (for unmodified and modified) 5 times?
Added the Hectic Cleave Sims below:
- Hectic Add Cleave (Not modified) - 130,797 DPS
- Hectic Add Cleave (Modified) - 130,347 DPS
Not much difference ๐ค
Trying with Patchwerk with 3 bosses below using my Single Target gearset:
- Patchwerk with 3 Bosses (Not modified) - 131,698 DPS
- Patchwerk with 3 Bosses (Modified) - 140,193 DPS
That's a big change. If you would like me to run more sims but with gear normalised then let me know what to use? ๐ I have most of the trinkets if it helps (ranging from heroic to mythic)
It's less about gear. Honestly, the best comparison is to run the most common talent/azerite/essence combinations vs. Patchwerk / HAC / Patchwerk x5.
I think that APL still needs work around its multi-target, based on those sim results.
At best, I'd have to try hybridizing my modified version in the addon with your modified version from SimC.
I've been iterating over this APL and -05 and -06 both include the changes. -06 fixes some bugs with the -05 implementation. I hope.