[REC] Affliction Warlock cleave does not recommend summon_darkglare
EricMiukyQin opened this issue · 5 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this issue (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Describe the Issue
In WarlockAffliction.lua, shadow_embrace max_stack is either 2 or 4 depending on talent. However in cleave APL, shadow_embrace.stack must be 3 when shadow_embrace talent is enabled, which causes this issue when talent drain_soul is inactive.
How to Reproduce
No response
Snapshot (Link)
Raidbots Sim Report (Link)
No response
Additional Information
No response
Contact Information
No response
The line is identical in the actual sim. The max stacks is 4 because you have the talent, so it is possible to stack it to 3, isn't it? 3 shadow bolts would do it? max stacks =/= possible stack values.
max stack of 4 could have 0, 1, 2, 3, 4.
In your snapshot you have 0 stacks.
Additionally, please provide a Raidbots quicksim of your character.
What I mean is that if u have talent shadow_embrace enabled, in the first condition, u would check if debuff.shadow_embrace.stack is exactly equal to 3. However, if u have no talent drain_soul enabled at the same time, the maxium shadow_embrace stack should be 2 instead of 4 and the stack could never equal to 3, which causes this condion never be true.
debuff.shadow_embrace.stack = 3
3 might be a variable instead of a constant, which should be similar as what u did in the code
I'm following. I'll adjust the Shadow Embrace stack checks to be appropriate for DS vs. SB.