[REC] Assassination Rogue Cold Blood different spell id with Fatebound / Inevitability
mztikk opened this issue ยท 5 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this issue (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Describe the Issue
When talented into Inevitability from fatebound the spell and buff id of cold blood changes from 382245 to 456330 and thus getting stuck at recommending at cold blood since it doesnt detect the buff being active and spell being on cd
How to Reproduce
Take Fatebound and Inevitability
Snapshot (Link)
Raidbots Sim Report (Link)
No response
Additional Information
No response
Contact Information
No response
The constant Cold Blood priority recommendation was fixed, but now it gets recommended as soon as the buff is gone, even if Cold Blood is on cooldown.
I was able to resolve this issue by modifying the Cold Blood talent in RegisterAbilities:
Line 1901:
id = function() return talent.inevitability.enabled and 456330 or 382245 end,
Added new line after 1915:
copy = { 382245, 456330 },
The constant Cold Blood priority recommendation was fixed, but now it gets recommended as soon as the buff is gone, even if Cold Blood is on cooldown.
I was able to resolve this issue by modifying the Cold Blood talent in RegisterAbilities:
Line 1901:
id = function() return talent.inevitability.enabled and 456330 or 382245 end,Added new line after 1915:
copy = { 382245, 456330 },
Yes I forgot to change the ability ID too, I only did the buff by mistake.
PR Opened: #3629
Just need Hekili's review