[FEATURE] Add Variable for Buff Blessing of An'she
holytobi opened this issue ยท 6 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this request and was not able to find one.
- I edited the title of this feature request (above) so that it describes the issue I am reporting.
Feature Request
if miss a variable in hekili. If i try to use "buff.blessing_of_anshe.up" the value is in any case false.
https://www.wowhead.com/spell=445200/blessing-of-anshe
So i think it's not implemented, because it's not in the "simcraft" rotation. But this is wrong (u can't ignore a 200% buff on HoW -.-) Simcraft will update this but maybe hekili can be earlier so i can write my own rotation :-)
Additional Information
No response
Contact Information
No response
ok i checked the code it is implemented. I found an Registered Talent and an Aura and the Spell IDs are correct. it seams more like a bug that its false. Have to check the code deeper if i find the error
It's probably not tracked. Can you get the spellID from in-game of the actual buff, not the talent?
i can find in the retribution.lua at "RegisterAuras" this lines:
"-- The healing or damage of your next Holy Shock is increased by $s1%.
blessing_of_anshe = {
id = 445204,
duration = 20.0,
max_stack = 1
},"
this spell id is correct. i can create ingame a WeakAura with the id and it works.
iam not familar with your project so i don't know if it needs more for working ingame correctly. otherwise i would fix it and create a pull request. Maybe if u fixed it, u can post here the solution or reason why it dosent worked so i can help the next time
It was using the Holy spec version spellID, I fixed this with #3683