Hekili Priority Helper

Hekili Priority Helper

Addons
50M Downloads

[REC] Hammer of Light recommended with insufficient Holy Power

benkimball opened this issue ยท 1 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this issue (above) so that it describes the issue I am reporting.
  • I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Paladin - Protection

Describe the Issue

Starting with commit 5c61d30, Hekili began recommending Hammer of Light when I had only 2 holy power. By reverting this change to PaladinProtection.lua, the previous behavior (Hammer of Light only recommended with 3 holy power or more) was restored.

How to Reproduce

  1. Enter the game as protection paladin
  2. My talent build: CIEAE74QAafj6bdTrgpLZS4VlvNjZwix2DYGzMW2MzMmxMzYGAAAAAAAAAA0WDzMziBmZYmZxgxsBAjBAwAGgBAYmptZZWmBIwmZA
  3. Attack target dummy and follow recommendations
  4. The third time Hammer of Light is recommended, around 60s into the fight, observe that it cannot be cast because you only have 2 holy power

Snapshot (Link)

https://pastebin.com/BWFUyxac

Raidbots Sim Report (Link)

No response

Additional Information

I can reliably fix the issue locally by reverting that change to the PaladinProtection.lua file. (I keep all my addons in a git repository so that I can easily see changes.)

Contact Information

No response

commented

I will test a fix (updating reset_precast in PaladinProtection.lua to replace existing code with:

    if IsActiveSpell( 429826 ) then applyBuff( "hammer_of_light_free" ) end
    if IsActiveSpell( 427453 ) then applyBuff( "hammer_of_light_ready", 12 - ( query_time - action.eye_of_tyr.lastCast ) ) end