Hekili Priority Helper

Hekili Priority Helper

50M Downloads

[REC] 25% lower AoE dps than sim (Fire mage)

sixsi opened this issue · 14 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this issue (above) so that it describes the issue I am reporting.
  • I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Mage - Fire

Describe the Issue

As a Fire mage, I'm doing less DPS than my sim shows. The Combustion window is fine DPS-wise, but outside of Combustion, my DPS drops significantly, and I can't recover with the next Combustion. In my specific case, the sim shows almost 1.9M DPS on 5 dummies during a 3-minute fight, while following the addon recommendations, I'm doing about 1.4M DPS on 5 dummies over 3 minutes, which is around 25% less.

Again, the Combustion window is fine and performs as well as the sim shows, but afterward, something goes wrong, and the addon recommends spamming multiple Fireballs in a row even though I have 3 charges of Fire Blast available.

I took a snapshot around 5 seconds after Combustion when the addon started recommending Fireball spam. I'd appreciate it if you could check the Fire Mage rotation. Thanks for your help!

How to Reproduce

Enter the game as a Fire Mage.
Use AoE talents from high-ranking players.
Start your rotation on 5 dummies and wait until your Combustion window finishes.
At some point, the addon will struggle with recommendations and suggest spamming Fireballs, even though you have your Fire Blasts back.

Snapshot (Link)

https://pastebin.com/kp4XfZ0K

Raidbots Sim Report (Link)

https://www.raidbots.com/simbot/report/gseyt7TmznGQdEikPAGWQD

Additional Information

No response

Contact Information

No response

commented

Are there any places where these under-the-hood improvements needed are documented? I see this issue is tagged as backlog.

commented

I see the sim casts some Fireballs in a row, but again, something is clearly wrong because I'm doing 25% less DPS on a 3-minute, 5-dummy fight.

commented

Yeah, you're playing fire mage, that's what happens. Unfortunately fire mage is the 1 dps spec that cannot compete with sim dps using the addon (Currently). It requires some under the hood improvements.

commented

I was just leaving it up to Hek whether or not to close the ticket. Eventually, I will set aside time to go through the spec. Maybe when I do I will reach out for asssistance.

commented

Fire is actually in a much more addon-friendly state than previous expansions.

For a comparison in recommendations to have much value, I'd need a snapshot with multiple recommendations (4+) taken after exiting the Combustion window to see if it differs significantly from the sim behavior.

commented

Fire is actually in a much more addon-friendly state than previous expansions.

For a comparison in recommendations to have much value, I'd need a snapshot with multiple recommendations (4+) taken after exiting the Combustion window to see if it differs significantly from the sim behavior.

Do you want the snapshot just outside of combustion window or when it begins to recommend fireball 3+ times in a row even though you have stacks and instant pyros ready? I can test any and all of this today.

commented

Will do. I’ll have these incoming in about an hour.

commented

You can test both/all situations, just make sure you note which snapshot is which and why you believe it is wrong at that time.

commented

You can test both/all situations, just make sure you note which snapshot is which and why you believe it is wrong at that time.

Do you want the issues I find here or open my own ticket?

commented

https://pastebin.com/aCS7Tewt - Sunfury AoE Opener not recommending a hard casted Flame Strike on pre-pull.

https://paaster.io/eIiSN5yhZw5N4m-gvECm-#Z46DrqIGty2HC5PiUM7yg0HzolUd-XOfGBpxbG4OBjo - (Sorry for not using pastebin but apparently fire aoe snapshot is too large for free users to post.) This SS is taken as soon as fire ball is being recommended in aoe far more than it should be, it made me hard cast fire ball 4-6 times each test while stacks of Pheonix Flames and Fire Blast were available. This happens with 25 ish seconds left on combustion cd.
(https://www.raidbots.com/simbot/report/vYA66rYaQWvyNzX6pdkzv2 Here is AoE SIM for both snapshots.)

commented

https://pastebin.com/aCS7Tewt - Sunfury AoE Opener not recommending a hard casted Flame Strike on pre-pull.

This is a spec setting you need to enable in the Fire Mage addon settings (or from the minimap icon).

From your snapshot
pyroblast_pull = false

This setting allows hard casted pryoblasts and flamestrikes during prepull.

https://paaster.io/eIiSN5yhZw5N4m-gvECm-#Z46DrqIGty2HC5PiUM7yg0HzolUd-XOfGBpxbG4OBjo - (Sorry for not using pastebin but apparently fire aoe snapshot is too large for free users to post.)

Save it as a .txt file and attach it directly here on Github, if pastebin won't allow it.

commented

SunFuryAoE.txt
Here is AoE Fire ball spam.

SunfuryFireOpener.txt
Here is the opener recommending Pyroblast as the opener regardless of having pure aoe selected.

commented

RE: Opener

Flame strike AOE requires 4 targets, but your AOE display is set to 3.

With flame strike build, you still use pyro at 3 targets as per sims and guide.

Non-issue.

RE: fireball spam

Will check this later

commented

RE: Opener

Flame strike AOE requires 4 targets, but your AOE display is set to 3.

With flame strike build, you still use pyro at 3 targets as per sims and guide.

Fixed thanks<3