[REC] VDH Fel Dev and Meta empowered abilities and cooldown resets are not implemented correctly
dubudevs opened this issue · 8 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this issue (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Spec
DH - Vengeance
Describe the Issue
Metamorphosis (the spell) resets the cooldown of Sigil of Flame and Fel Devastation (violent transformation) and empowers them (demonic intensity). When you are in meta and you cast empowered fel dev (fel desolation) it recommends you to immediately press it again despite it going on a 40 second cooldown. When the cast finishes the recommendations fix themselves.
How to Reproduce
Play VDH
Play fel-scarred hero tree
Press meta
Observe recommendations, note multiple instances of fel desolation despite it having a 40s cd
Press fel desolation and observe the next recommendation with a 40s timer on it
One of these is before pressing fel dev, one is during the cast.
https://pastebin.com/7aU4ibUk
https://pastebin.com/K0wNReTN
Snapshot (Link)
Raidbots Sim Report (Link)
No response
Additional Information
No response
Contact Information
No response
Entering meta by pressing fel devastation with Demonic talented or by cheating with Last Resort does not proc the reset cd and empowered fel dev and SoF, only actually pressing meta.
Piggybacking this issue, in general Sigil of Doom cpm seems low. I dont have a specific snapshot, and I am not sure if its related to the same issue as the initial one. Will check some more when its fixed.
The issue is from line 1156 of https://github.com/Hekili/hekili/blob/thewarwithin/TheWarWithin/DemonHunterVengeance.lua
Violent Transformation and Demonic Intensity do not apply to Fel Dev or Fel Deso.
Remove lines
1156-1167
1180-1192
1254-1265
1278-1290
The Metamorphosis section at like 1463 seems to be the Havoc section, it needs to have what was removed from the fel dev/fel deso sections added to the meta section. Not sure if there is more there that needs to be updated, but the fel_scarred section thats in there just includes havoc skills and the rest of it includes havoc talents.
That alone doesnt seem to be enough to fix the SoD/Fel Deso recommendation problems, unfortunately I dont have enough knowledge to further diagnose :(
