[REC] periodic gain of stacks from bonestorm isn't implemented
kyatastrophe opened this issue ยท 4 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this issue (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Spec
DK - Blood
Describe the Issue
periodic gain of stacks from bonestorm isn't implemented causes over-recommendation of marrowrend
How to Reproduce
in bonestorm its overrecommending marrowrend if you fall below bone shield stacks
Snapshot (Link)
Raidbots Sim Report (Link)
https://www.raidbots.com/simbot/report/dTBQWdamdJLvWwBL8Cosvm
Additional Information
No response
Contact Information
kyatastrophe
Your snapshot shows that Marrowrend is being suggested because Exterminate is about to fall off, which is the right thing to do regardless of if Bonestorm is up or not.
Your snapshot shows that Marrowrend is being suggested because Exterminate is about to fall off, which is the right thing to do regardless of if Bonestorm is up or not.
What about the 2nd marrowrend?
For Recommendation 1, buff.bone_shield.stack == 6, but for Recommendation 3, buff.bone_shield.stack == 1. I don't see why that would happen since Recommendation 2 was just death_strike.
The issue is that the model for Bone Shield had max_stack = 1; stacks were appropriately taken from the API for the first recommendation, but the addon enforced its max_stack value after the first Marrowrend, which then caused the next Marrowrend condition to be met.
This is fixed for next release, and modeling the Bonestorm -> Bone Shield gains has also been added.