Hekili Priority Helper

Hekili Priority Helper

Addons
50M Downloads

[REC] Lava Lash prioritised too highly in AoE when Flameshock already spread

Nazacra opened this issue · 1 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this issue (above) so that it describes the issue I am reporting.
  • I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Shaman - Enhancement

Describe the Issue

I expect that in an AoE situation for a Stormbringer Storm Enhancement build Lava Last would not be recommended in AoE unless:

  1. Flameshock is active and needs to be spread/refreshed (up to 6 targets)
  2. There are no other available actions

This matches my expectation from both https://www.icy-veins.com/wow/enhancement-shaman-pve-dps-rotation-cooldowns-abilities?area=area_b and https://www.wowhead.com/guide/classes/shaman/enhancement/rotation-cooldowns-pve-dps#sb-aoe-rotations-elementalist

image
image

I expect the issue is with this part of the priority:

hekili/TheWarWithin/Priorities/ShamanEnhancement.simc

Line 120 in a9e0c3e

actions.aoe+=/lava_lash,if=talent.molten_assault.enabled&dot.flame_shock.ticking

The problem being that is higher than many other abilities such as Ice Strike / Sundering / Crash Lightning / etc, and it doesn't have any conditional other than "Has Molten Assault talent && Flame shock is ticking". This means that a lot of those other abilities will basically never be recommended due to Lava Lash having a short cooldown and Flameshock being up the majority of the time.

Interestingly the earlier check for Lava Lash appears to be more what I would expect:

hekili/TheWarWithin/Priorities/ShamanEnhancement.simc

Line 109 in a9e0c3e

actions.aoe+=/lava_lash,cycle_targets=1,if=talent.molten_assault.enabled&(talent.primordial_wave.enabled|talent.fire_nova.enabled)&dot.flame_shock.ticking&(active_dot.flame_shock<active_enemies)&active_dot.flame_shock<6

So it might be that the solution is to just flat out remove line 120? (i.e. actions.aoe+=/lava_lash,if=talent.molten_assault.enabled&dot.flame_shock.ticking) as I don't see why that is part of the rotation based on guides.

How to Reproduce

  1. Enter game as an Enh Shaman with an Elementalist build
  2. Perform opener on AoE Target dummies until after CDs / etc expire
  3. See that in non-opener/cd rotation Lava Lash is being recommended over other abilities when the other abilities are available

Snapshot (Link)

https://pastebin.com/VH9DJ0GS

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

commented

As far as I can tell from sims, this is intentional pending an official update of the priority in SimulationCraft. When SimC updates, I will.

  • 👍1