Rotation does not reset after a boss or a reset
geraint425 opened this issue · 10 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this issue (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Spec
Monk - Windwalker
Describe the Issue
Noticed a problem in the addon that rotation is not reset after defeating the boss or if we reset it. It thinks that I do not have ready sooldowns and breaks the opener in the addon. Displays the wrong rotation. Helps to fix everything /reload. But if we often reset the boss to update sooldowns addon again breaks and again have to do /reload. If the character dies and the boss reset the addon does not break the rotation. Only under this condition addon correctly displays rotation if the character died in the raid on the boss. And this problem occurs to me not only on the monk but also on the shaman, death knight. Similar situation. All the same conditions to perform on the shaman and death knight, the addon will also be broken in rotation.
How to Reproduce
- Go into a raid (no matter the difficulty)
- Start a fight with a boss
- Reset the boss to make it disappear, to reset сooldowns
- addon will display incorrect rotation (opener)
Snapshot (Link)
Raidbots Sim Report (Link)
No response
Additional Information
No response
Contact Information
No response
Dump: value=GetCVar("SoftTargetEnemy")
[1]="1"
Here I am just out of town. Just hit one Tiger palm ability and killed a mob. And the rotation didn't reset after leaving the battle to the original rotation. It thinks I'm still in the battle and offers further rotation. Although all the buttons are available threw screenshot. It should have returned me to the rotation Tiger Palm-Rising Sun Kick-Tiger Palm, but it did not happen.
It's not an automatic error. Which appears during the battle randomly. This is an error in the rotation display. You can personally check it on a monk if you have one.
You're saying it's the wrong rotation. What is the rotation supposed to be? You did not include a sim link or any explanation of what you think it's supposed to be, and you also don't seem to have a target selected in your snapshot either.
target_auras: target does not exist
Are you using Action Targeting Mode? When you run this macro in-game what does it say? /dump GetCVar("SoftTargetEnemy")
It seems to me the addon is fully aware that your cooldowns are up.
16. invoke_xuen_the_white_tiger ( cooldowns - 2 )
The action (invoke_xuen_the_white_tiger) is usable at (1.00 + 1.00).
17. storm_earth_and_fire ( cooldowns - 3 )
The action (storm_earth_and_fire) is usable at (1.00 + 1.00).
https://www.raidbots.com/simbot/report/gGJLYLMfgwudDxN2GEdNMQ
https://www.raidbots.com/simbot/report/1KYmWdiw78USDKSbXcfoZX
The rotation should start like this in the screenshot. You can as in another sim. But not as I have in the rotation goes. To now clearly show you I need to go again in the raid, start a fight with the boss and ask the raid leader that he reset the boss. I'm saying that this problem repeats only when the boss is restarted or defeated. I'm going to raid now to try to get in and show you why this happens. Since all abilities are there and ready, but addon does not recommend them as per Simcraft.
You can just stand in dornogal and input the macro I asked for /dump GetCVar("SoftTargetEnemy")
I think they aren't being recommended because you don't have a target, so the boss conditions are all failing.
Here are two screenshots, the target has already appeared and already I took him to the target a long time passed but the rotation still remained at the same recommendation. And the other screenshot where the correct rotation appeared I did just /reload and everything was fixed.
Sounds like a duplicate of #4272
Yeah, so as I thought it's related to the other ticket. It's because your last ability was tiger palm, and combo strikes doesn't want you to tiger palm twice in a row.
The reason reloading works is because it erases the fact that tiger palm was your last ability.
Previous combat spell was tiger palm
previous_spells:
1 - roll
2 - roll
3 - tiger_palm
When you reload, this list of spells gets erased.
Entry which should pick tiger palm, but combo_strike is false
12. tiger_palm ( normal_opener - 1 )
The action (tiger_palm) is usable at (0.00 + 0.00) with cost of 60 energy (have 120).
- the action is ready before the current recommendation (at +0.00 vs. +10.00).
List ( normal_opener ) called from ( Windwalker:default:6 ) would PASS at 0.00.
time[0.00] < 4 & active_enemies[1.00] < 3 & chi.deficit[4.00] > 0
- this entry's criteria FAILS: chi.current[2.00] < 6 & ( combo_strike[false] | ! talent.hit_combo.enabled[true] )
if you cast any other ability, like black out kick or something, this entry would show true I think. You can test if you want. That would probably also fix it instead of reloading.
So just watch ticket #4272 and wait for a permanent fix.
It would also work correctly if you untalented hit combo.
The cause of this situation is ending combat where your last spell was Tiger Palm.
Casting any of these other spells should fix it instead of reloading (except tiger palm of course), if that is less annoying for now.
spec:RegisterStateTable( "combos", {
blackout_kick = true,
chi_burst = true,
chi_wave = true,
crackling_jade_lightning = true,
expel_harm = true,
faeline_stomp = true,
jadefire_stomp = true,
fists_of_fury = true,
flying_serpent_kick = true,
rising_sun_kick = true,
rushing_jade_wind = true,
spinning_crane_kick = true,
strike_of_the_windlord = true,
tiger_palm = true,
touch_of_death = true,
weapons_of_order = true,
whirling_dragon_punch = true
} )