Performance hit when separate cooldown, interrupt, and/or defensive windows are open.
torda385 opened this issue · 3 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this bug report (above) so that it describes the issue I am reporting.
Describe the Issue
Every update cycle (0.5s?) the game stutters. This occurs only when all of the extra windows are open.
How to Reproduce
- Enter game as any specialty
- Get fresh, clean Hekili profile
- Enable cooldown, interrupt, and defensives as separate windows
- My LED monitor is sensitive to dropped frames, so it flashes brightly every half second
- To fix, disable the separate windows and it goes back to normal.
Player Information (Link)
Error Messages (Link)
Additional Information
Forgive me for being on mobile, but I think it might be in
local fullUpdate = self.NewRecommendations or self.timer < 0
line 1076 in UI.lua because each window flags it as NewRecommendations (and therefore fullUpdate).
Whereas if it's all in one window, it doesn't do the extra fullUpdate calls.
Is there a way do the full update once and then push the results to the windows instead of having each window do full updates each cycle?
Contact Information
No response
There isn't a way to do that because each display is independent by design. The separate displays function by setting different starting conditions for the recommendation engine. If you are having performance issues with separate cooldowns/defensives/interrupts, it's probably better to not have all of those as separate displays.
I think there are further optimization steps that Hekili can make to the recommendation engine to reduce the processing needed to genreate a recommendation, but some of that is just dependent on the complexity of the APL.
Instead of a separate cooldown display, just use the keybind to toggle the display of major cooldowns in the main recommendation display. That will greatly help by halving the amount of processing needed.