[REC] Fire Mage addon recommends Pyroblast while casting Scorch without Heating Up buff present
mwojtkowski opened this issue ยท 8 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this issue (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Spec
Mage - Fire
Describe the Issue
While testing rotation on target dummies in Dornogal I noticed that addon will recommend Pyroblast as next action while casting Scorch without Heating Up buff present.
Conditions were
- Combustion was on CD
- 0 charges on both Fire Blasts and Phoenix Flames
- no Heating Up buff
- no Hot Streak buff
How to Reproduce
- Disable CDs
- Take Tareget dummy to execute range
- Use up all your Fire Blasts and Phoenix Flames
- Addon will suggest Scorch into Pyroblast while having no Heating Up buff
Snapshot (Link)
Raidbots Sim Report (Link)
No response
Additional Information
No response
Contact Information
No response
Looks to me like this is happening because you have combustion disabled (due to your toggle), but you procced combustion from something. So parts of the fireball entries are failing because it thinks you can't click combustion.
Might be possible to tweak the cooldown.combustion.remains_expected expression to work better when CDs are toggled off.
I did multiple snapshots yesterday, and I had to pick up one with Combustion buff up xD
But it happens regardless of the CD toggle.
From what I saw in snapshots, it looks to me like the addon thinks that buff.heating_up.up is true, which is not present at that moment, but it will be after the cast of Scorch is finished.
This is a snapshot with CDs toggle ON (I used CDs off in the original post because it is faster to get to that point where the issue occurs) and no Comustion buff up this time.
and screenshot
Couldn't find option to set Target Dummy initial hp so this is Execute Patchwerk without any buffs
https://www.raidbots.com/simbot/report/4TpicYCKQobi4bGDcduDqS
Thanks for that. I think I was able to figure it out.
So there is a tiny delay between scorch hitting and generating the hotstreak/heatup. Basically what's happening is that the sims already account for this, so when they're asking buff.heating_up.up, they mean "right as soon as scorch finished, but before it lands". So they're asking "did you get heating up from the previous spell?"
In the addon we assume scorch to be instant (because projectiles are complicated), so when it asks buff.heating_up.up, we're asking "did THIS scorch give heating up"?
Since the question is slightly different, the APL is interpreted wrong. I will come up with something for it. So I guess technically you were right about the desync of the buff, but for a different reason.
There's more info about it here, too: #3178
If that suggested change has been put in, we may be able to convert scorch to a projectile.
After some more testing and snapshots, I think I know what is going on with this.
There are 2 similar lines in APL:
actions.combustion_phase+=/pyroblast,if=prev_gcd.1.scorch&buff.heating_up.react&active_enemies<variable.combustion_flamestrike&buff.combustion.up
/pyroblast,if=prev_gcd.1.scorch&buff.heating_up.react&scorch_execute.active&active_enemies<variable.hot_streak_flamestrike
Scenario:
- Heating Up buff is down
- Hot Streak buff is down
- Fire Blast charges = 0
- Phoenix Flames charges = 0
- We are currently casting Scorch
Because we are now castign Scorch:
- addon will add the current cast to prev_gcd - prev[1].scorch is now true
- Scorch handler function is called, and in it hot_streak function - now buff.heating_up.up is true (this is in the future i.e. after cast is finished )
Target is in the execute range
- scorch_execute.active is true
With the above APL line is true, buff state is in the future while prev_gcd.1.scorch and scorch_execute.active are in the present.
With the above APL line is true, buff state is in the future while prev_gcd.1.scorch and scorch_execute.active are in the present.
They're all in the future, because the addon is making a recommendation for after scorch, so all of those conditions are correct. Can you post a quicksim for a target dummy in execute?
