Before You Begin

• I confirm that I have downloaded the latest version of the addon.
• I am not playing on a private server.
• I checked for an existing, open ticket for this issue and was not able to find one.
• I edited the title of this issue (above) so that it describes the issue I am reporting.
• I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Mage - Frost

Describe the Issue

I didnt think it worked like this, but it appears it does. I think its a change this patch.

FoF is consumed instead of winter's chill.

To clarify, the addon consumes both, but in game only one is consumed.

How to Reproduce

Hit dummy until you have fof and it recommends flurry>lance>lance>x https://pastebin.com/2CMhfkRe , you cast flurry>lance and it will change to recommend lance>lance>x https://pastebin.com/7PD5TYBj instead of lance>x because the target still has 2 stacks of winter's chill.

Snapshot (Link)

see replication steps

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

This is quite a large damage loss, tried fixing myself but was not able to fix remaining_winters_chill calculations and I couldn't figure it out from the limited addon documentation

Could you rephrase in a more structured way? It's honestly hard for me to track whether you're saying it should recommend Flurry > Lance > Lance > X or it should recommend Flurry > Lance > Lance > Lance > X (when you have FoF and there are 2 stacks of Winter's Chill).

It's far easier (for me) to grasp if you provide clear steps in complete, numbered steps.

I do:

1. ...
2. ...
3. ...

I see:

1. ...
2. ...
3. ...

I should see:

1. ...
2. ...
3. ...

@Hekili
When you cast Ice Lance while you have the Fingers of Frost buff up, it doesn't consume the Winter's Chill debuff.

Basically, the addon should track when Fingers of Frost are removed and be aware that Ice Lance, which consumed Fingers of Frost, does not consume Winter's Chill stack.

In a situation where:

• Winter Chill is on 2 stacks.
• Fingers of Frost have 1 stack up.
• We have Ray of Frost ready.
• We won't have enough Icicles to cast Glacial Spike.

Addon will suggest:

1. Ice Lance
2. Ray of Frost
3. Ice Lance

First Ice Lance is in flight and the addon thinks remaining_winters_chill is 1.
Because remaining_winters_chill is 1 actions.st_ff+=/ray_of_frost,if=remaining_winters_chill=1 is now true.
After the first Ice Lance hits the target, Winter's Chill stack is updated to the real value of 2, and the addon will suggest Ice Lance again.

Addon should suggest:

1. Ice Lance
2. Ice Lance
3. Ray of Frost

Because first Ice Lance consumed Fingers of Frost and didn't remove Winter's Chill debuff .

I was trying a few things myself.

import LibRangeCheck

local RC = LibStub( "LibRangeCheck-3.0" )

added fingers_of_frost_removed frost_info

spec:RegisterStateTable( "frost_info", {
    last_target_actual = "nobody",
    last_target_virtual = "nobody",
    watching = true,

    fingers_of_frost_removed = 0
    -- real_brain_freeze = false,
    -- virtual_brain_freeze = false
} )

In COMBAT_LOG_EVENT_UNFILTERED

if sourceGUID == GUID and spellID == 44544 and ( subtype == "SPELL_AURA_REMOVED" or subtype == "SPELL_AURA_REMOVED_DOSE" ) then
    frost_info.fingers_of_frost_removed = GetTime()
end

Register a fake aura to tell the addon that we removed FoF with Ice Lance.

fingers_of_frost_consumed = {
    duration = function() 
        local _, maxR = RC:GetRange( "target" )
        maxR = maxR or 40
        return maxR / class.abilities[ "ice_lance" ].velocity
    end,
    -- maybe this should be 2 if we have enough haste to lower GCD
    -- so that we can cast 2nd Ice Lance before first hits the target
    max_stack = 1,
}

In the reset_precast, check if we cast Ice Lance before FoF was removed and the event is within 150ms.

if action.ice_lance.lastCast > 0 and frost_info.fingers_of_frost_removed >= action.ice_lance.lastCast and action.ice_lance.lastCast - frost_info.fingers_of_frost_removed < 0.15 then
    applyBuff( "fingers_of_frost_consumed" )
end

modified remaining_winters_chill to skip increasing projectiles if fingers_of_frost_consumed.up

spec:RegisterStateExpr( "remaining_winters_chill", function ()
    local wc = debuff.winters_chill.stack

    if wc == 0 then return 0 end

    local projectiles = 0

    for spender in pairs( wc_spenders ) do
        if spender == "ice_lance" and buff.fingers_of_frost_consumed.up then -- do nothing
        elseif action[ spender ].in_flight and action[ spender ].in_flight_remains < wc then projectiles = projectiles + 1 end
    end

    return max( 0, wc - projectiles )
end )

modified Ice_lance impact function

impact = function ()
    removeDebuff( "target", "frozen" )
    if talent.frostfire_mastery.enabled then
        if buff.excess_fire.up then
            removeStack( "excess_fire" )
            addStack( "excess_frost" )
            BrainFreeze()
        end
    end
    if not buff.fingers_of_frost_consumed.up then removeDebuffStack( "target", "winters_chill" ) end
end

and in handle I've replaced removeStack( "fingers_of_frost" ) with

if buff.fingers_of_frost.up then
    removeStack( "fingers_of_frost" )
    applyBuff( "fingers_of_frost_consumed" )
end

Tested on version v11.1.0-1.0.12 that has commit a489e9e and it is still happening

Primary Icon set to 1 Icon display

Addon recommended Ray of Frost on 2 Winter's Chill debuff

snapshot https://pastebin.com/LmkDFX72