Before You Begin

• I confirm that I have downloaded the latest version of the addon.
• I am not playing on a private server.
• I checked for an existing, open ticket for this issue and was not able to find one.
• I edited the title of this issue (above) so that it describes the issue I am reporting.
• I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Mage - Frost

Describe the Issue

Frostfire Bolt is also a Winter's Chill spender, it should be added to wc_spenders array that is used in remaining_winters_chill function

How to Reproduce

When at 1 Winter's Chill cast Frostfire Bolt, addon will sugest Winter's Chill spending ability untill Frostfire Bolt hits the target

Snapshot (Link)

https://pastebin.com/2qmKwx3h

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

Do you have a snapshot showing that?

Sorry, after profile reset and addon reinstallation it works as intended

Also adding Frostfire Bolt to wc_spenders fixed remaining_winters_chill value and now addon recommends proper spells

Thanks for confirming, fix submitted.

This is already coded

        impact = function ()
            applyDebuff( "target", "chilled" )
            removeDebuffStack( "target", "winters_chill" )
            applyDebuff( "target", "frostfire_bolt" )
        end,

@Hekili Do we need to add in_flight stuff in all the winters chill related APL entries? Is there a better solution? If an entry is chosen because of winters_chill stacks, and it will consume it on impact, and is in flight, it shouldn't be allowed to choose another entry which is fighting for that same stack.

It's sort of invalidating a previous entry because the "current" entry would probably hit first and consume that stack.

Queued event #2 (frostfire_bolt PROJECTILE_IMPACT) due at 1.08; checking pre-event recommendations.

        34.  ice_lance ( st_ff - 8 )
        The action (ice_lance) is usable at (0.51 + 0.00) with cost of 25000 mana (have 2450049).
         - the action is ready before the current recommendation (at +0.00 vs. +10.00).
        List ( st_ff ) called from ( Frost Mage:default:7 ) would PASS at 0.00.
        talent.frostfire_bolt.enabled[true]
         - this entry's criteria PASSES: buff.fingers_of_frost.up[false] | remaining_winters_chill[1.00]
        Excluded 0.00 recheck time as it is outside our constraints ( 0.00 - 1.07 ).
        Excluded 2.46 recheck time as it is outside our constraints ( 0.00 - 1.07 ).
        Excluded 2.46 recheck time as it is outside our constraints ( 0.00 - 1.07 ).
        Excluded 2.46 recheck time as it is outside our constraints ( 0.00 - 1.07 ).
        Action chosen:  ice_lance at 0.00!
        Texture shown:  %s
        Exiting st_ff with recommendation of NO ACTION at +10.00s.
        Returned from list (st_ff), current recommendation is ice_lance (+0.00).
        - [st_ff]
        Added st_ff to blocklist as it was called via RAL.
        The recommended action (ice_lance) is ready in less than 0.2s; exiting list (default).
        Exiting default with recommendation of NO ACTION at +10.00s.
 
    Completed default action list [ Frost Mage - default ].
    Recommendation is ice_lance at 0.51 + 0.00.
    Recommendation #1 is ice_lance at 0.00s (0.51s).
    Time spent generating recommendations:  2.07ms

This might be a bigger scale change, not just frost specific? It would have a use-case for survival hunter tip of the spear as well.

It looks to me like remaining_winters_chill is already supposed to handle this, but isn't? Is it because Frostfire bolt isn't listed here?

local wc_spenders = {
    frostbolt = true,
    glacial_spike = true,
    ice_lance = true,
}

Okay false alarm that was me way overthinking things. Adding frostfire_bolt to the table of wc_spenders fixes it, will submit change.

Also I suggest adding state:IsCasting(spender) to remaining_winters_chill

if state:IsCasting( spender ) and (action[ spender ].in_flight and action[ spender ].in_flight_remains < wc) then projectiles = projectiles + 1 end

because addon will recommend Ice Lance while casting Glacial Spike with 1 Winter's Chill left on the target

Do you have a snapshot showing that?