Hekili Priority Helper

Hekili Priority Helper

53M Downloads

[REC] Elemental Shaman not getting recs for House of Cards trinket

saltmastergeneral opened this issue ยท 3 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this issue (above) so that it describes the issue I am reporting.
  • I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Shaman - Elemental

Describe the Issue

House of cards does not recommend until sometimes at the end of a fight and even then it is sporadic.

How to Reproduce

1.enter game
2. select target and begin rotation
3. see House of cards does not get recommended
4.

Snapshot (Link)

https://pastebin.com/Xmnd5pT9

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

commented

I will need to go over the APL again, there are conditions on them for that 2min vs 3 min ascendance thing

commented

Yeah, this is an issue where the only entry for House of Cards requires either:

  • variable.special_items is true (which, for House of Cards, requires First Ascendant AND your other trinket does not have a use-buff)
  • You're in a boss fight with fewer than 21 seconds remaining

We probably just need an entry for House of Cards that is just a simplified trinketX entry, when special_items is false:

  • actions+=/house_of_cards,use_off_gcd=1,if=!variable.special_items&((buff.fury_of_storms.up|!talent.fury_of_the_storms|cooldown.stormkeeper.remains>10)&(cooldown.primordial_wave.remains>25|!talent.primordial_wave|spell_targets.chain_lightning>=2)&cooldown.ascendance.remains>15|boss&fight_remains<21|buff.ascendance.remains>12)

Alternately, we need to see a Raidbots sim that shows whether this defect occurs in the sim or if this is an issue with how trinket1 and trinket2 work in the addon vs. SimC.

commented

The Sims are pretty weird about it due to the strict ascendance timings (removed on our side). I'll look into some tweaks that solve both the remaining ascendance issues and the trinkets.