Before You Begin

• I confirm that I have downloaded the latest version of the addon.
• I am not playing on a private server.
• I checked for an existing, open ticket for this issue and was not able to find one.
• I edited the title of this issue (above) so that it describes the issue I am reporting.
• I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Shaman - Enhancement

Describe the Issue

The shaman enhancement APL has in the check for skyfury buff a check for active_dot. im assuming this is an error as it is a buff not a dot and buffs are buff.

How to Reproduce

look at the apl

Snapshot (Link)

http://THIS TEMPLATE IS SILLY

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

This is not an error. Skyfury is counted as a dot so that you can count how many are active. If you join a group, cast it, and check active_dot.skyfury you'll see that it is accurate.

The template is also not silly, because if you had followed it I would've been able to show you an example of the skyfury count working. :)

@syrifgit so I guess I could have been more clear

1. I wanted to bring up something that is not an issue with the addon working, no template really allows this? Yet templates are forced. This is what I meant by silly.
2. the APL is unintuative? I see active_dot and think dot is debuff not buff, so while it may work would there not be a better way to handle this?
3. Maybe I just havn't found a use but searching the simc github for active_dot yields resaults all of which are checking for a debuff never a buff while this doesn't mean the implementation here won't work its again not unintuative? when buff exists, though this would only show on player not group maybe intruduce a different item like active_buff?

I don't know the hekili code in depth but, if it does infact check for buffs if active_dot, then is it not possible that you could run into a situation where there is a buff and debuff of the same name but you go to use active_dot and it finds the wrong one?

the APL is unintuative? I see active_dot and think dot is debuff not buff, so while it may work would there not be a better way to handle this?

This is only done in specific cases to allow a bit of extra functionality. The addon isn't really designed for tracking buffs on allies, so this is a workaround for cases like raid buffs, and other individually chosen spells. For example, the functionality has been added to earth shield for shamans, to allow an APL interaction that knows if you have a shielded ally or not. I also added it to a few healer HoTs. Aug Evoker also uses it to count Prescience. That's basically the extent of it.

4. Maybe I just havn't found a use but searching the simc github for active_dot yields resaults all of which are checking for a debuff never a buff while this doesn't mean the implementation here won't work its again not unintuative? when buff exists, though this would only show on player not group maybe intruduce a different item like active_buff?

This addon is not SimC and they are not exactly 1:1, hence all the warning messages when you try to import your own profile from SimC. There is translation that occurs because WoW has certain APIs available (and certain things that are not available), and addons run in LUA. SimulationCraft is a vacuum, and written in C++, and has 0 API restrictions because it doesn't matter what Blizzard says. It's their own sandbox that can do whatever it's coded to do.

I don't know the hekili code in depth but, if it does infact check for buffs if active_dot, then is it not possible that you could run into a situation where there is a buff and debuff of the same name but you go to use active_dot and it finds the wrong one?

It does check for buffs too, but only ones that are specifically given this tag because they have a reason to be counted. The overwhelming majority of buffs do not because counting them does not matter.

Example of a buff you can count with active_dot.x

    -- Mastery increased by $w1% and auto attacks have a $h% chance to instantly strike again.
    skyfury = {
        id = 462854,
        duration = 3600,
        max_stack = 1,
        shared = "player",
        dot = "buff"
    },

Example of buffs you cannot count with active_dot.x (except it will count the one on yourself, I think, but not allies)

    -- Maximum health increased by $w3%.
    downpour = {
        id = 207778,
        duration = 6.0,
        max_stack = 1
    },

    -- Heals $w1 every $t1 sec.
    -- https://wowhead.com/ptr-2/spell=382024
    earthliving_weapon = {
        id = 382024,
        duration = 12,
        max_stack = 1
    },

Hope that explains it.

@syrifgit

This is only done in specific cases to allow a bit of extra functionality. The addon isn't really designed for tracking buffs on allies, so this is a workaround for cases like raid buffs, and other individually chosen spells. For example, the functionality has been added to earth shield for shamans, to allow an APL interaction that knows if you have a shielded ally or not. I also added it to a few healer HoTs. Aug Evoker also uses it to count Prescience. That's basically the extent of it.

This addon is not SimC and they are not exactly 1:1, hence all the warning messages when you try to import your own profile from SimC. There is translation that occurs because WoW has certain APIs available (and certain things that are not available), and addons run in LUA. SimulationCraft is a vacuum, and written in C++, and has 0 API restrictions because it doesn't matter what Blizzard says. It's their own sandbox that can do whatever it's coded to do.

I get it just trying to help. I author a few addons. And I know you guys have added a few things simc does not have, just thought maybe including something like active_buffs instead of reusing existing simc API for something it doesn't do would make it a bit easier to make and adjust APL for those maybe less knowledgable on the hekili API?(also thought you guys might have something like active_buffs in and maybe it was just a mistake) I suppose as well if its use in this way is very limitied writing a whole new bit of code just for this is not really worth it. Anyways, didn't mean to be a bother just some thoughts. Thanks! Have a nice day!