Hekili Priority Helper

Hekili Priority Helper

53M Downloads

[BUG] Hekili Life Tap Glyph Detection Bug on Chinese WoW 3.4.4 Servers

roam55 opened this issue · 0 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this bug report (above) so that it describes the issue I am reporting.

Describe the Issue

I am a Chinese player. Chinese servers have updated to include Transmogrification, and the underlying code has been changed to the Cataclysm version. We now have a special version 3.4.4, which is causing Life Tap glyph detection to fail.
Looking at my Hekili addon (version 3.4.4-1.0.7 for Affliction Warlock), I noticed a bug where Life Tap always shows 'false' in my conditions. The screenshot shows the condition 'mana.pct < 10 | glyph.life_tap.enabled & buff.life_tap.remains < 2' but glyph.life_tap.enabled always displays as 'false' even though I have the glyph.
I also found this note in the addon description: '2023-02-27: Fix Life Tap logic to not refresh w/o glyph active.', but the simc showed the logic is correct as below.

Image

Image

Additionally, if I remove the 'glyph.life_tap.enabled' part from the condition, I encounter another issue: when my Life Tap buff has about 5 seconds remaining, Hekili will display Life Tap as the recommended action for all 4 upcoming skill slots. It continues to show only Life Tap until I actually cast Life Tap, after which it returns to normal recommendations.
Can you help me understand what's causing these issues and how to fix them? Is it because our server's unique version is incompatible with how Hekili detects glyphs?

How to Reproduce

  1. Log into the game on Chinese servers (running special version 3.4.4, with updated Transmogrification system)
  2. Use an Affliction Warlock character who has learned the Life Tap glyph
  3. Open Hekili settings (type /hekili)
  4. Check the Life Tap condition settings in the priority list
  5. Observe that glyph.life_tap.enabled always displays as false, even though the character has learned this glyph
  6. If you remove the glyph.life_tap.enabled condition, when Life Tap buff has less than 5 seconds remaining, Hekili will display Life Tap for all 4 upcoming skill recommendations
  7. Only after casting Life Tap will the skill recommendations return to normal

Player Information (Link)

build: v3.4.4-1.0.7 level: 80 (80) class: WARLOCK spec: warlock talents: amplify_curse bane contagion deaths_embrace empowered_corruption eradication everlasting_affliction haunt improved_corruption improved_curse_of_agony improved_felhunter improved_life_tap improved_shadow_bolt intensity malediction nightfall pandemic ruin shadow_embrace shadow_mastery siphon_life soul_siphon suppression unstable_affliction pvptalents: none covenant: none conduits: none soulbinds: none sets: none gear: = 1 mainhand = 1 legendaries: none itemIDs: 4344, 45294, 45446, 45466, 45495, 45518, 45933, 47419, 47422, 47454, 47462, 47489, 47795, 47797, 47804, 47807, 48032, 48667 settings: aoe = 3 buffPadding = 0 combatRefresh = 0.1 custom1Name = 自定义 1 custom2Name = 自定义 2 cycle = false cycle_min = 6 damage = true damageDots = false damageExpiration = 6 damagePets = false damageRange = 0 debuffPadding = 0 enabled = true enhancedRecheck = false gcd = 687 gcdSync = true maxTime = 10 nameplateRange = 8 nameplates = false noFeignedCooldown = false package = 痛苦 petbased = false potion = wild_magic regularRefresh = 0.5 throttleRefresh = false throttleTime = false usePackSelector = true affliction = 痛苦 demonology = 恶魔 (wowtbc.gg) destruction = 毁灭 group_curse = curse_of_agony group_type = party inferno_enabled = true shadow_mastery = true solo_curse = curse_of_agony toggles: cooldowns = true custom1 = false custom2 = false defensives = false essences = false [overridden] interrupts = false mode = single potions = false keybinds: blood_fury = Z [05] corruption = 1 [01] curse_of_agony = 3 [01] curse_of_doom = A1 [05] death_coil = G [06] demonic_circle_summon = AX [01] demonic_circle_teleport = X [05] drain_soul = SR [06] fel_armor = A2 [06] haunt = E [06] inferno = 5 [01] life_tap = 4 [01] potion = 1 [08] seed_of_corruption = F [06] shadow_bolt = Q [06] shadow_ward = 8 [01] shadowflame = AE [06] soulshatter = T [06] unstable_affliction = 2 [01]

Error Messages (Link)

583x DugisGuideViewerZ/QuestPOI.lua:272: bad argument #1 to 'pairs' (table expected, got nil) [C]: in function 'pairs' [DugisGuideViewerZ/QuestPOI.lua]:272: in function 'HookLandMarks' [DugisGuideViewerZ/DugisGuideViewer.lua]:4475: in function <DugisGuideViewerZ/DugisGuideViewer.lua:4473> [DugisGuideViewerZ/DugisGuideViewer.lua]:4494: in function <DugisGuideViewerZ/DugisGuideViewer.lua:4493> [C]: in function 'OnMapChanged' [Blizzard_MapCanvas/Blizzard_MapCanvas.lua]:39: in function <...aceBlizzard_MapCanvas/Blizzard_MapCanvas.lua:28> [tail call]: ? [DugisGuideViewerZ/LuaUtils.lua]:895: in function 'DugiSetMapToCurrentZone' [DugisGuideViewerZ/DugisGuideViewer.lua]:4447: in function <DugisGuideViewerZ/DugisGuideViewer.lua:4443> Locals: (*temporary) = nil (*temporary) = "table expected, got nil"

Additional Information

No response

Contact Information

No response