Hekili Priority Helper

Hekili Priority Helper

53M Downloads

[BUG] Feral Druid Brutal Slash Fails to Update active_bt_triggers and Trigger bt_swipe Buff After Recent Changes

PIPA12344 opened this issue · 6 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this bug report (above) so that it describes the issue I am reporting.

Describe the Issue

Three days ago, I submitted an issue (#4678) describing a problem where Brutal Slash was incorrectly adding 2 stacks to active_bt_triggers, along with a suggestion to reset active_bt_triggers when reaching 3. After updating to the new version, I've observed the following persistent issues:

Functionality Regression: Brutal Slash now fails to increment active_bt_triggers at all
Buff Trigger Failure: The buff.bt_swipe.up state is not being triggered by Brutal Slash
Reset Mechanism Broken: active_bt_triggers still exceeds 3 and isn't properly reset

Partial Fix Attempt:
Restoring deleted bt_brutal_slash code segments
Removing bt_brutal_slash alias references in bt_triggers resolved the duplicate increment issue
However, the check_bloodtalons function remains non-functional i can't fix it

Additional Observation:
The handler function for Brutal Slash contains applyBuff("bt_swipe") which should:

Trigger buff.bt_swipe.up
Increment active_bt_triggers by 1

But neither occurs. Could this be related to the check_bloodtalons function call within the same handler?

How to Reproduce

Play Feral Druid Spec

Player Information (Link)

/

Error Messages (Link)

/

Additional Information

No response

Contact Information

No response

commented

Please provide snapshots where you think this is happening.

  • one after casting brutal slash
  • one where by triggers is more than 3
commented

@syrifgit
After casting Brutal Slash:
Image

After casting Rake,Shred Thrash and Moonfire
Image

commented

Not a picture.

https://github.com/Hekili/hekili/wiki/Report-An-Issue#how-do-i-get-a-snapshot

After casting Brutal Slash: https://pastebin.com/vSPQvy2f
After casting Rake,Shred Thrash and Moonfire: https://pastebin.com/wMivH7wN

commented

Perfect, thank you

commented

Fix posted