Before You Begin

• I confirm that I have downloaded the latest version of the addon.
• I am not playing on a private server.
• I checked for an existing, open ticket for this issue and was not able to find one.
• I edited the title of this issue (above) so that it describes the issue I am reporting.
• I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Mage - Frost

Describe the Issue

If you have 1 stack of Winter's Chill on the enemy and 5 icicles the addon will recommend glacial spike>ice lance however only one of these abilities will shatter.

In game the ice lance shatters (it travels faster) so you gain an icicle, however you lose a large amount of damage from not shattering glacial spike.

How to Reproduce

Get 5 icicles
Press flurry
Ice lance until you have no FoF and 1 WC
Observe recommendations

Snapshot (Link)

https://pastebin.com/zvAsA2W5

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

It's challenging to review this in simc because Winter's Chill isn't set up to be tracked in the sample sequence. Ugh.

If you're so inclined, you might remove or action.glacial_spike.in_flight from line 724 and see if the result is more like you'd expect (both in terms of recommendations and DPS output).

This seems to make a big difference

I dont think this change was commited

This fix still doesn't appear to be live

Can you provide new snapshots and info then?

Mage is ready/live for 11.2, so should be working.

Can you provide new snapshots and info then?

Mage is ready/live for 11.2, so should be working.

https://pastebin.com/AavpnKDV

The fix hekili posted fixes this issue it was just never commited. Glacial spike should not refund a charge.

I can open a PR for it. Can you show me exactly what you mean by "the fix"? His screenshot in comment above?

I can open a PR for it. Can you show me exactly what you mean by "the fix"? His screenshot in comment above?

remove or action.glacial_spike.in_flight from line 724

Frostbolt and Frostfire bolt consume winters chill but also grant an icicle. Ice lance only grants an icicle when it consumes fingers of frost or winters chill, so you want to fire a frostbolt and then ice lance to consume the last stack of winters chill with the lance so you get 2 icicles instead of just 1 (consuming chill with bolt doesn't grant an extra stack).

However, with glacial spike you want to consume the chill with the spike for the damage buff. Hence remove the glacial spike part of this.

This logic should also only trigger if the enemy has exactly 1 stack of winter's chill and you have no stacks of fingers of frost. I am not sure if that would be an improvement to recommendations but I can try it if you can recommend how I can implement it. There are cases when it recommends dry firing an ice lance and I believe this could fix it.