Hekili Priority Helper

Hekili Priority Helper

53M Downloads

[REC]UH DK - ST opener not reflecting sim

Closed this issue · 12 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this issue (above) so that it describes the issue I am reporting.
  • I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

DK - Unholy

Describe the Issue

As the title says, the opener for UH DK ST with raid talents does not reflect the sim. The addon suggests starting with raise abomination, dark transformation etc while the sim starts with death and decay + festering strike.

How to Reproduce

  1. enter game as UH DK
  2. select raid talents
  3. check recommendation queue
  4. hit ST dummy

Snapshot (Link)

https://pastebin.com/rvKG8hwb

Raidbots Sim Report (Link)

https://www.raidbots.com/simbot/report/2FWraNjsEzxKNKL6YwJk76

Additional Information

No response

Contact Information

No response

commented

Thanks; it looks like there's an old entry for Army/Abom in the precombat action list that needs to be removed. You can try going to /hekili > Priorities > Unholy, Action Lists, then selected Action List: precombat, Entry: 2, and uncheck Enabled. I'll do more testing later.

commented

Thanks; it looks like there's an old entry for Army/Abom in the precombat action list that needs to be removed. You can try going to /hekili > Priorities > Unholy, Action Lists, then selected Action List: precombat, Entry: 2, and uncheck Enabled. I'll do more testing later.

This does not change anything unfortunately

commented

My brother in Christ, your snapshot is Rider of the Apocalypse spec and your sim is San'layn.

commented

My brother in Christ, your snapshot is Rider of the Apocalypse spec and your sim is San'layn.

I can provide a snapshot of the Raise Abom out of order for priority and sim if you'd like me to add to this ticket or open a new one?

commented

Looks like disabling actions 21 and 22 from "default" will remove Raise Abom/Army from the queue. This probably doesn't help much but figured I'd add my findings here until told otherwise.

I'm sure disabling those 2 is not ideal, at all, but I thought it was interesting that the "precombat" adjustment Hekili mentioned did not have an affect but these two did. In fact, you have to disable both of them in order for Army to disappear, if one or the other are enabled than the ability returns to the front of the queue.

commented

First of all, apologies for blowing up this ticket but I think I have a "fix" for now, at least on my end testing it out it seems to work in ST.
I had to disabled Precombat Army of the dead, and default entry 21, then added this condition to entry 22 under default action list.
(cooldown.apocalypse.remains>35)

This at least forces army/raise abom to be after you have used it, recently. Apoc is 45s cd so 35s gives ~10 seconds to use it.

commented
commented

My brother in Christ, your snapshot is Rider of the Apocalypse spec and your sim is San'layn.

I also checked the snapshot again and hero tree is San. What did you mean?

commented

Thanks; it looks like there's an old entry for Army/Abom in the precombat action list that needs to be removed. You can try going to /hekili > Priorities > Unholy, Action Lists, then selected Action List: precombat, Entry: 2, and uncheck Enabled. I'll do more testing later.

The conditions for abom are missing.

actions+=/raise_abomination
should be
actions+=/raise_abomination,if=(variable.st_planning|variable.adds_remain)&(!talent.vampiric_strike|(pet.apoc_ghoul.active|!talent.apocalypse))|boss&fight_remains<30

commented

Thanks; it looks like there's an old entry for Army/Abom in the precombat action list that needs to be removed. You can try going to /hekili > Priorities > Unholy, Action Lists, then selected Action List: precombat, Entry: 2, and uncheck Enabled. I'll do more testing later.

The conditions for abom are missing.

actions+=/raise_abomination should be actions+=/raise_abomination,if=(variable.st_planning|variable.adds_remain)&(!talent.vampiric_strike|(pet.apoc_ghoul.active|!talent.apocalypse))|boss&fight_remains<30

where should I change this? Also the rec opener is not reflecting the sim for some reason

commented

PR submitted