[REC] Shadow - Triple Back to Back VT rec
Shooooom opened this issue ยท 6 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this issue (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Spec
Priest - Shadow
Describe the Issue
I don't have a snapshot because it only happens when I raid. But very frequently when I play Voidweaver (especially in bloodlust) I get recommended VT to proc unfurling darkness and if I follow the rec, I finish casting it before the debuff for unfurling darkness runs out.
I did fix it for myself by adding a small buffer to the Unfurling Darkness VT recs. So there is at least 0.3*execute time pause after debuff runs out and before VT is recommended. Like this:
[1386547] :: Cast Vampiric Touch to proc Unfurling Darkness with Inner Quietus talented
actions.main+=/vampiric_touch,cycle_targets=1,if=buff.unfurling_darkness_cd.remains<(execute_time*0.7)&talent.unfurling_darkness&!buff.dark_ascension.up&talent.inner_quietus&active_dot.vampiric_touch<=5
[1386547] :: Cast Vampiric Touch to proc Unfurling Darkness without Inner Quietus talented
actions.filler+=/vampiric_touch,cycle_targets=1,if=talent.unfurling_darkness&buff.unfurling_darkness_cd.remains<(execute_time*0.7)
Idk if there's a more elegant way to fix it. If it's a ping issue maybe there could be an option to buffer VT so people can adjust it for themselves, like a slider when you right click the minimap icon.
How to Reproduce
Not sure exactly. But might have something to do with super high haste windows with PI and Bloodlust. Though it does seem to happen out of lust as well.
Snapshot (Link)
Raidbots Sim Report (Link)
No response
Additional Information
No response
Contact Information
No response
Please get a proper snapshot during the time you think the recommendation is incorrect.
Instructions: https://github.com/Hekili/hekili/wiki/Report-An-Issue#how-do-i-get-a-snapshot
It was hard to reproduce on dummies but here it is.
At the moment of the snapshot, I'm casting VT that was the previous rec and it ended up not proccing Unfurling Darkness as the cast finished before the debuff ran out
Looks like there was still 0.18 seconds left on debuff as I finished casting VT
- vampiric_touch ( main - 21 ) The action (vampiric_touch) is usable at (0.98 + 0.00). - the action is ready before the current recommendation (at +0.00 vs. +5.18). List ( main ) called from ( Shadow:default:5 ) would PASS at 0.00. NONE
- this entry's criteria PASSES: buff.unfurling_darkness_cd.remains[0.18] < execute_time[1.18] & talent.unfurling_darkness.enabled[true] & ! buff.dark_ascension.up[false] & talent.inner_quietus.enabled[true] & active_dot.vampiric_touch[1.00] <= 5
Action chosen: vampiric_touch at 0.00!
Texture shown: %s
Exiting main with recommendation of vampiric_touch at +0.00s.
Returned from list (main), current recommendation is vampiric_touch (+0.00).- [main]
Added main to blocklist as it was called via RAL.
Exiting default with recommendation of vampiric_touch at +0.00s.
- [main]
here's a better snapshot where you can see the VT that didn't proc UD gets recommended
- vampiric_touch ( main - 21 )
The action (vampiric_touch) is usable at (0.48 + 0.00).- the action is ready before the current recommendation (at +0.00 vs. +2.76).
List ( main ) called from ( Shadow:default:5 ) would PASS at 0.00.
NONE - this entry's criteria FAILS: buff.unfurling_darkness_cd.remains[1.34] < execute_time[1.18] & talent.unfurling_darkness.enabled[true] & ! buff.dark_ascension.up[false] & talent.inner_quietus.enabled[true] & active_dot.vampiric_touch[1.00] <= 5
Excluded 0.00 recheck time as it is outside our constraints ( 0.00 - 2.76 ).
Excluded -3.99 recheck time as it is outside our constraints ( 0.00 - 2.76 ).
There are 1 recheck events.
Times: 0.17091689830646
List ( main ) called from ( Shadow:default:5 ) would PASS at 0.17.
NONE
Recheck 1 ( +0.17 ) MET: buff.unfurling_darkness_cd.remains[1.17] < execute_time[1.18] & talent.unfurling_darkness.enabled[true] & ! buff.dark_ascension.up[false] & talent.inner_quietus.enabled[true] & active_dot.vampiric_touch[1.00] <= 5
Action chosen: vampiric_touch at 0.17!
Texture shown: %s
Time spent on this action: 0.26ms
TimeData:Shadow-main-21:vampiric_touch:x1:0.26:Ability Known, Enabled(0.02):Post-TTR and Essential(0.02):Post Cycle(0.00):Post Usable(0.00):Post Ready/Clash(0.01):Post Stack(0.02):Pre-Script(0.00):Post-Script(0.01):Pre-Recheck(0.04):Post-Recheck Times(0.02):Pre-Recheck Loop(0.02):Recheck Loop Start(0.00):Recheck Post-Usable(0.01):Recheck Post-Stack(0.01):Recheck Post-Script(0.03):Recheck Post-Channel(0.00):Recheck Loop End(0.02):Post Recheck Loop(0.00):Post Recheck(0.00):Action Stored(0.01)
The recommended action (vampiric_touch) is ready in less than 0.2s; exiting list (main).
Exiting main with recommendation of vampiric_touch at +0.17s.
Returned from list (main), current recommendation is vampiric_touch (+0.17). - [main]
Added main to blocklist as it was called via RAL.
Exiting default with recommendation of vampiric_touch at +0.17s.
- the action is ready before the current recommendation (at +0.00 vs. +2.76).
It looks like it's just the narrow margin of VT vs. the Unfurling Darkness ICD. I'll look into padding the cooldown since it looks like it's too easy to queue ahead of the recommended time.