[REC] Junkmaestro's Mega Magnet
Closed this issue ยท 5 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this issue (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Spec
Rogue - Outlaw
Describe the Issue
Junkmaestro's Mega Magnet trinket doesn't lose it's stacks if your target dies shortly after using the trinket on it. I am looking to modify the recommendation to add the condition to the existing entry or add it elsewhere in the list so that if my target is about to die, use the trinket. This is a dps increase for any class able to use the trinket, but won't be shown in SimC as it is likely a bug.
No matter how I adjust the condition or add a new condition, Junkmaestro's is always ignored in the priority as it says "IsUsable returned false". If I try to have the action call Trinket 1 instead, it will bypass it saying that Junkmaestro's is used elsewhere in the priority. If I remove all references to Junkmaestro's in the priority, it still claims it is being used elsewhere.
It seems the behaviour for how Outlaw Rogue uses this trinket is hard coded and isn't modifiable in the priority? Or I'm just misunderstanding, in which case I would still recommend modifying the condition to try to snipe targets before they die for a dps increase. Adding "target.time_to_die <= 2 | " to entry 28 of cd list would be enough I think?
How to Reproduce
- Use a character that has the Junkmaestro's Mega Magnet trinket equipped.
- Add an action to precombat or anywhere else unmissable: Action - Junkmaestro's Mega Magnet. Condition - buff.junkmaestros_mega_magnet.stack >1
- Hit a target dummy until your trinket stacks are 2 or more. At this point you would expect to see the trinket be recommended but it won't.
Snapshot (Link)
Raidbots Sim Report (Link)
No response
Additional Information
No response
Contact Information
Grayfox2325
Aside from that, it looks like the usable function requires more than 28 stacks
usable = function() return buff.junkmaestros_mega_magnet.stack > 28 end,
So no matter what conditions you have, you need 29+ stacks for the addon to consider it usable.
I have like 50 snapshots throughout the process of me trying to figure this out. I've tried with it in only in once, same result. Which would be explained by the fact that I guess you need more than 28 stacks lol. Where can I see that? I'm fine to edit it myself if it's not a change that you want to make for everyone.
Where can I see that? I'm fine to edit it myself if it's not a change that you want to make for everyone.
addon folder/Hekili/TheWarWithin/Items.lua, but you'll need to maintain the edit after every addon update.