Before You Begin

• I confirm that I have downloaded the latest version of the addon.
• I am not playing on a private server.
• I checked for an existing, open ticket for this issue and was not able to find one.
• I edited the title of this issue (above) so that it describes the issue I am reporting.
• I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Paladin - Protection

Describe the Issue

buff.hammer_of_light_ready.up is not working after updating addon, basically is recommending SOTR even when i need 3 HP to cast HoL

How to Reproduce

1. Use Tyr
2. Check SOTR is rec before HoL

Please get a proper snapshot during the time you think the recommendation is incorrect.

Instructions: https://github.com/Hekili/hekili/wiki/Report-An-Issue#how-do-i-get-a-snapshot

CD: https://pastebin.com/qzqig3pQ
Primary: https://pastebin.com/L3BEYR4S

tbh, idk where is coming this sotr

This appears to be a custom pack with incorrectly written conditions causing LUA errors. When submitting issues be sure to use the default pack.

Sorry, forgot to change to default prio

https://pastebin.com/pyQN4BAn

Hammer of light is not in that display.

        31.  hammer_of_light ( standard - 2 ) - ability disabled ( display )
        Time spent on this action:  0.02ms
        TimeData:Protection Paladin-standard-2:hammer_of_light:x0:0.02:Ability Known, Enabled(0.02)

Better paste: https://pastebin.com/eCk7Fp6e

Again, hammer of light is not part of your cooldowns display that you are submitting snapshots of.

        30.  hammer_of_light ( standard - 2 ) - ability disabled ( display )
        Time spent on this action:  0.02ms
        TimeData:Protection Paladin-standard-2:hammer_of_light:x0:0.02:Ability Known, Enabled(0.02)

You need to provide the snapshot of whatever display you have the spell assigned to (via toggles)

Download old version

CDS: https://pastebin.com/RKdcZ73j
Primary: https://pastebin.com/nEQ3fBS3

Working as it should.

New Version

CDS: https://pastebin.com/UE9kZVbq
Primary: https://pastebin.com/yLZ4LThC

Both versions are recommending hammer of light just fine? What is the issue?

New Version
CDS: https://pastebin.com/UE9kZVbq
Primary: https://pastebin.com/yLZ4LThC

Protection Paladin; Primary - hammer_of_light(0.00), hammer_of_light(1.16), avengers_shield(2.32)

    Completed default action list [ Protection Paladin - default ].
    Recommendation is hammer_of_light at 0.00 + 0.00.
    Recommendation #1 is hammer_of_light at 0.00s (0.00s).

Download old version
CDS: https://pastebin.com/RKdcZ73j
Primary: https://pastebin.com/nEQ3fBS3

Protection Paladin; Primary - hammer_of_light(0.00), avengers_shield(1.10), judgment(2.20)

    Completed default action list [ Protection Paladin - default ].
    Recommendation is hammer_of_light at 0.00 + 0.00.
    Recommendation #1 is hammer_of_light at 0.00s (0.00s).

Its even in your screenshot?

Ok, check SOTR conditions:

( ! talent.righteous_protector.enabled | cooldown.righteous_protector_icd.remains = 0 ) & ! buff.hammer_of_light_ready.up

how its showing when we have a hol free ready to go?

Old version never do it, if you have hol ready, it will never recommend sotr as would eat 3hp from hol

It's telling you to cast it in 10.96 seconds, not right now.

Protection Paladin; Cooldowns - shield_of_the_righteous(10.96)

You may want to add a cooldown indicator, or not use 2 separate displays.

That makes sense, but still a weird change from a version to another.
I enjoy having only offgcd stuff on cooldowns, and always work fine for me before.

Thanks!