Hekili Priority Helper

Hekili Priority Helper

53M Downloads

[FEATURE] raidevent.add.in via DBM or BW

Closed this issue ยท 2 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this request and was not able to find one.
  • I edited the title of this feature request (above) so that it describes the issue I am reporting.

Feature Request

raidevent.add.in is widly used in the action packs
https://github.com/search?q=repo%3AHekili%2Fhekili+adds.in&type=code

but it returns a hardcoded value

hekili/State.lua

Line 1375 in a5b6140

["in"] = 3600, -- raid_event.adds.in appears to return time to the next add event, so we can just always say it's waaaay in the future.

BigWigs or DeadlyBossMods are widly used among wow players and provide an API for other plugin to fetch this infos. We could create a list of seasonal "adds.in" events and check if they are upcomming.

required stuff

  • array with adds_in_events[BOSS_ID][EVENT_ID]
  • listen for plugin events and track the ability if it is usefull to us
  • logic that fetches time if boss_id is in array and checks for nearest event_id duration
  • fallback to current solution if there is none of the addons installed
  • maybe setting to disable the feature

technical infos

WeakAura has the ability to interact with them - maybe interesting reference https://github.com/WeakAuras/WeakAuras2/blob/4f48c4cc587134e73f8910c5942bf9f411893170/WeakAuras/BossMods.lua#L1011

edit: asked in BW discord and got following infos:

hekili will want to track internally how much time is left on bars by listening to the  starttime and stoptimer events etc. 
https://github.com/BigWigsMods/BigWigs/blob/master/Plugins/Bars.lua#L1079-L1083
https://github.com/BigWigsMods/BigWigs/blob/master/Core/BossPrototype.lua#L3224 
_Timer and _StopBar

via https://discord.com/channels/289409313565573131/290888929576747017/1366735645166538786

edit: also asked on the DBM discord. We would also need to listen to the events. They recommended me to look at the weak aura code that does pretty much the same.

DBM hooks; https://github.com/WeakAuras/WeakAuras2/blob/4f48c4cc587134e73f8910c5942bf9f411893170/WeakAuras/BossMods.lua#L163
BigWigs hooks; https://github.com/WeakAuras/WeakAuras2/blob/4f48c4cc587134e73f8910c5942bf9f411893170/WeakAuras/BossMods.lua#L849

via https://discord.com/channels/157608978124242945/225365755212988416/1366744851927928884

Well bossMod is both boss mods, you just use those and that's it, works iwth both. don't use the deprecated BigWigs and DBM specific calls, those will be removed eventually

alternative solution

just pull the adds.in event timers from BW and track the time based on this values - eg:
https://github.com/BigWigsMods/BigWigs/blob/master/LiberationOfUndermine/Rik.lua#L53

pros

  • better recommendations in raid boss fights
  • edit: in the long run we could also recommend defensives for aoe damage and tankbusters

cons

  • another seasonal list that needs config
  • apis can break, would need aditional work in the future to fix them

Additional Information

No response

Contact Information

No response

commented

This is already being slowly worked on. But there are a lot of other things that need to be done first to support this.

commented

Just adding: this is being explored, but isn't guaranteed -- the feature would need to be assessed against the addon's design intent and what API capabilities exist by the time we get there.

So this is a "we'll see" right now. Going to close the ticket since the conversation will need to be based on a potentially different addon landscape when the time comes.