Before You Begin

• I confirm that I have downloaded the latest version of the addon.
• I am not playing on a private server.
• I checked for an existing, open ticket for this issue and was not able to find one.
• I edited the title of this issue (above) so that it describes the issue I am reporting.
• I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Paladin - Holy

Describe the Issue

I'm trying to add a check to holy shock to only recommend it with 2 charges or maybe > 1.5 but cooldown.holy_shock.charges always return 0.

How to Reproduce

I just added it to the action conditions and it's always 0

Snapshot (Link)

n/a

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

Looks like holy shock can't even be disabled at all in the abilities tab or by disabling the action itself.

You should attach a snapshot. I can't recreate both issues:

Charges:
Holy Shock toggle (manually putting it into the first spot in the APL):
Before disable (A5 keybind):
After disable (gone):

https://pastebin.com/MDwZ9rPR

When it was never updating was me being a dumb dumb, I had it set to cooldowns required and had that off. I just setup the same thing you did with a fractional cooldown check (did just charges= 2 as well) and the issue seems to be the cooldown is just wrong. It'll recommend holy shock way before the second charge is ready.

Those errors are from before I changed it to "cooldown.holy_shock.charges_fractional > 1.99" this does show the charges updating when hovering my mouse over it so it should be correct? The problem seems to be the timing is not matching with the real cooldown of holy shock.

Edit: I did a complete delete/data and all and reinstalled the addon to make sure it wasn't broken. But I still get the cooldown.holy_shock.charges_fractional variable not matching to the real cooldown.

This variable cooldown.holy_shock.charges will change to 2 when the second charge is still only 1/4 of the way off cooldown.

The cooldown was coded incorrectly, I'll be submitting a PR within the next day to fix that and also clean up various other interactions for hpal

Fix posted: #4866

tl;dr: The cooldown was very wrong. It was set to 8.5 base instead of 9.5 with haste scaling, and the 2 second reduction from casting crusader strike was modifying the base cooldown, and so was the infusion of light talent. So basically, it was being registered as like a 5.5 second cooldown with certain talent builds lol.

Thanks for figuring that out. :)

I did see one other issue with shining righteousness. There is 2 different buffs, one is the stacking buff and the other is the actually free word of glory cast. I think you have the wrong spell id for it (414445) seems to be the right one... I think, I'm not real sure on this stuff tbh. edit: nvm, I think it's another shining_righteousness_ready

Crusader strike and judgment are also hasted cooldown