Exclude the Single-Button Assistant from being recommended by Hekili
AhoyThere opened this issue · 8 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this request and was not able to find one.
- I edited the title of this feature request (above) so that it describes the issue I am reporting.
Feature Request
Hello,
as everyone else I'm curious about the Single-Button Assistant and how it performs. So besides using always using Hekili I also added the SBA to my Action Bar (F12 for example). I have no doubt that Hekili is superior but I still wanted to try. Most often Hekili's suggestion is different from what the SBA would do. But every once in the while they are suggesting to use the same ability I guess and in that moment Hekili suggests using the Hotkey I've put the SBA on.
Therefore my question is, can I tell Hekili to just ignore the SBA, like you can tell Hekili to ignore Abilities, and/or can you tell Hekili to ignore a certain Hotkey.
I know it's a minor problem and it will most likely solve itself once Blizzard removes the SBA again but still...
Thanks in advance.
Additional Information
No response
Contact Information
No response
You can manually assign any keybind to an ability in the abilities page of the addon settings.
Thank you for your answer. I'm not sure if I understand it tho. If I drag the SBA to a Hotkey Slot, let's say F12, can I tell Hekili to ignore/not recommend that Hotkey? The goal is to Hekili not show/recommend the SBA ability. I don't see how the abilities page does this.
If you tell the addon that Frostbolt is on 6, then it does not matter what key it's actually on .. it will say 6. Outside of that, not really sure anything can really be done due to the way keybinds are read from the game. I would probably choose between the assist and the add-on though, simply for the reason that they do different rotations and that will make it harder to learn.
Thank you for your answer again. I have to admit I still don't understand you tho and I'm not sure if it is because you don't understand me (or what my "problem" is) or if what you are saying is completely logical and it's totally a me problem. But I can't explain it any better so I just give up. Sorry
I'll look into it and see if it would be easy to do, but as it stands the addon doesn't have a way to ignore specific keybinds, only to set them (per-ability).
So I think this is doable, with something like the following.
-- 1) Build a list of action-slots to ignore (Blizzard’s one-button assistant)
local ignoreSlots = {}
if HasAssistedCombatActionButtons and HasAssistedCombatActionButtons() then
local slots = FindAssistedCombatActionButtons()
if slots then
for _, slotID in ipairs( slots ) do
ignoreSlots[ slotID ] = true
end
end
endWhere both HasAssistedCombatActionButtons() and FindAssistedCombatActionButtons() are new API calls in-game.
Then inside ns.ReadKeybindings() we just skip those slots like so
if _G["Bartender4"] then
table.wipe( slotsUsed )
for i = 1, 180 do
if not ignoreSlots[ i ] then
local binding = GetBindingKey( "CLICK BT4Button" .. i .. ":Keybind" )
if binding then
StoreKeybindInfo( ceil( i / 12 ), binding, GetActionInfo( i ) )
slotsUsed[ i ] = true
end
end
endIs this something worth adding?
I came here looking for this exact solution. I do not want to have to manually specify every keybind for every ability in Hekili. The fact that it finds the keybind for me is its greatest strength, but it getting confused and seeing an on the One Button Assist keybind and using it vastly confuses things. The ability to tell Hekili to ignore specific keys would be extremely appreciated.