Windwalker CD's disappearing from spell qeue before use and not being recommended again
Closed this issue ยท 6 comments
Before You Begin
- I confirm I am using the latest version of the addon (outdated versions may have problems that were fixed on the newest release).
- I confirm I am playing on official Blizzard servers (not private servers).
- I checked for an existing, open ticket for this issue and was not able to find one.
- I have updated the issue title to clearly describe the problem.
- I am reporting an issue with the default specialization priority (not a custom or imported priority).
Specialization
Monk - Windwalker
Describe the Issue
Windwalker opener shows cooldown in spell qeue and when it comes turn to use those (Xuen and SEF) they disappear before used and are not recommended again.
How to Reproduce
- Enter game as windwalker
- Walk up to Single Target Dummy
- Hekili will show Tiger Palm >Rising Sun Kick >Tiger Palm > Xuen > SEF
- After pushing TP > RSK > TP your CDs will disappear from spell qeue and not be recommended again.
What is your information source?
Based on Class Guides (e.g., IcyVeins, Wowhead)
Snapshot (Link)
Raidbots Sim Report (Link)
https://www.raidbots.com/simbot/report/58yRKgYMYgjUYdxeQ6A4wh
Additional Information
Same applies to Crackling Jade Lightning when at 20 stacks. Not being recommended.
Contact Information
Discord Moistbuddha#7828
We need the snapshot taken when the issue is occurring. In this case, it would be after you've pressed the first three an Invoke was expected to be recommended.
I'm pretty sure something is wrong with fight_remains in xuen_condition. I don't fully understand why it would be used in the first place. Wouldn't we just never use any cooldown with bosses that take longer than 30 seconds to kill?
Good case:
https://pastebin.com/P9N6GDeE
variable.xuen_condition[true] ... fight_remains[29.99]
Bad case:
https://pastebin.com/PQXCVJ4z
variable.xuen_condition[false] ... fight_remains[299.19]
The xuen_condition value is not translating well from the Simc APL for Shado-Pan spec. From the Hekili APL:
active_enemies = 1 & ( time < 10 | talent.xuens_bond.enabled & talent.celestial_conduit.enabled ) | active_enemies > 1 & cooldown.storm_earth_and_fire.ready & fight_remains > 14 & ( active_enemies > 2 | debuff.acclamation.up | ! talent.ordered_elements.enabled & time < 5 ) & ( chi > 2 & talent.ordered_elements.enabled | chi > 5 | chi > 3 & energy < 50 | energy < 50 & active_enemies = 1 | prev.tiger_palm & ! talent.ordered_elements.enabled & time < 5 ) | boss & fight_remains < 30
For single target, the logic is extremely restrictive and will only be true if time is less than 10 seconds or if fight_remains is less than 30 seconds. So, it will tend to not be recommended outside of an opener or finisher.
The source Simc APL:
(fight_style.DungeonSlice&active_enemies=1&(time<10|talent.xuens_bond&talent.celestial_conduit)|!fight_style.dungeonslice|active_enemies>1)&cooldown.storm_earth_and_fire.ready&(target.time_to_die>14&!fight_style.dungeonroute|target.time_to_die>22)&(active_enemies>2|debuff.acclamation.up|!talent.ordered_elements&time<5)&(chi>2&talent.ordered_elements|chi>5|chi>3&energy<50|energy<50&active_enemies=1|prev.tiger_palm&!talent.ordered_elements&time<5)|fight_remains<30|fight_style.dungeonroute&talent.celestial_conduit&target.time_to_die>14
The first parenthetical expression deals with configuring the sim to do things depending on the fight_style and the active_enemies = 1 & ( time < 10 | talent.xuens_bond.enabled & talent.celestial_conduit.enabled ) | active_enemies > 1 from the Hekili APL is a remnant of this. I believe this whole part should be removed as using Xuen in the opener is managed by the APL naturally.
Modified xuen_condition:
cooldown.storm_earth_and_fire.ready & fight_remains > 14 & ( active_enemies > 2 | debuff.acclamation.up | ! talent.ordered_elements.enabled & time < 5 ) & ( chi > 2 & talent.ordered_elements.enabled | chi > 5 | chi > 3 & energy < 50 | energy < 50 & active_enemies = 1 | prev.tiger_palm & ! talent.ordered_elements.enabled & time < 5 ) | boss & fight_remains < 30
This will tend to hold Xuen until a SEF charge is available which may not be ideal of course, but it will recommend it. Probably someone more versed in making an APL for WW would be able to alter it so it is less linked to SEF.