Hekili Priority Helper

Hekili Priority Helper

Addons
53M Downloads

[BUG] Prevoker lua

Closed this issue ยท 3 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this bug report (above) so that it describes the issue I am reporting.

Describe the Issue

There is problematic code on line 821 which throws an error when taking snap shot:

if talent.essence_burst.enabled then GenerateEssenceBurst( 0.2, max( 2, ( group or health.percent < 100 and 2 or 1 ), action.living_flame.spell_targets ) ) end

I've fixed this locally as

if talent.essence_burst.enabled then GenerateEssenceBurst( 0.2, max( 1, ( ( group or health.percent < 100 ) and 2 or 1 ), action.living_flame.spell_targets or 1 ) ) end

This part of the lua could probably be cleaned up for clarity

How to Reproduce

  1. Create Snapshot with Alt Shift P

Player Information (Link)

....

Error Messages (Link)

.......

Additional Information

No response

Contact Information

No response

commented

Why not just PR the fix?

commented

This is the Lua Error

Message: ...ce/AddOns/Hekili/TheWarWithin/EvokerPreservation.lua:821: bad argument #3 to 'max' (number expected, got boolean)
Time: Sat Aug 16 04:01:13 2025
Count: 2
Stack:
[C]: ?
[Interface/AddOns/Hekili/TheWarWithin/EvokerPreservation.lua]:821: in function 'handler'
[Interface/AddOns/Hekili/State.lua]:6646: in function 'RunHandler'
[Interface/AddOns/Hekili/State.lua]:6454: in function 'HandleEvent'
[Interface/AddOns/Hekili/State.lua]:7108: in function 'advance'
[Interface/AddOns/Hekili/Core.lua]:1802: in function 'Update'
[Interface/AddOns/Hekili/Options/Options.lua]:9872: in function 'MakeSnapshot'
[Interface/AddOns/Hekili/Options/Options.lua]:9838: in function 'TogglePause'
[Interface/AddOns/Hekili/Options/Options.lua]:9972: in function 'FireToggle'
[Interface/AddOns/Hekili/UI.lua]:2873: in function <Interface/AddOns/Hekili/UI.lua:2872>

Locals:
(*temporary) = 2
(*temporary) = 1
(*temporary) = false
(*temporary) = "number expected, got boolean"

I am not sure if my fix is correct fix or just a band aid lol

commented

Resolved by 3b42563