Hekili Priority Helper

Hekili Priority Helper

53M Downloads

Frostscythe multi-target priority not respecting Remorseless Winter condition

Ruler124 opened this issue · 19 comments

commented

Before You Begin

  • I confirm I am using the latest version of the addon (outdated versions may have problems that were fixed on the newest release).
  • I confirm I am playing on official Blizzard servers (not private servers).
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I have updated the issue title to clearly describe the problem.
  • I am reporting an issue with the default specialization priority (not a custom or imported priority).

Specialization

DK - Frost

Describe the Issue

Frostscythe should trigger on 3 targets only when Remorseless Winter is active, but currently it is not used in this scenario.

How to Reproduce

1.Enter the game and fight vs 3 dummys till remoreless winter buff is up

What is your information source?

Based on my own Raidbots Quick Sim results

Snapshot (Link)

https://pastebin.com/b8q0PffJ

Raidbots Sim Report (Link)

https://www.raidbots.com/simbot/report/bYwRnPaCUFtAGCCyCQGVu1

Additional Information

No response

Contact Information

No response

commented

Isn’t Frostscythes conditions based on killing machine? Not RW?

The conditions for it are the same as Oblit as in AoE you exchange one ability for the other

commented

There's an error (typo) in the APL, it Will be looked at.

commented

Was about to report this, I'm getting obliterate recommended on 3 targets with remorseless winter instead of frostscythe.

commented

Yeah against 3 targets, with Cleaving Strikes talented and Remorsless Winter active, I only get Obliteration recommendations.

commented

If you have 4p tier on rider, the threshold increases to 4 targets in the APL under certain conditions. Maybe part of the cause?

commented

Adding this snapshot from the new version: https://pastebin.com/riVVSM8G

The frostscythe variable forgot how to do math, will be resolved Soon (TM)

commented

Just updated to the latest release and Frostscythe still not being recommended with Rider 4 set on 3 targets while RW is active

commented

Then you should snapshot that and add it here

commented

As noted in Discord, I'm not able to replicate this issue any longer. Make sure your addon is updated and that you haven't made edits to your Frost DK priority.

        50.  frostscythe ( aoe - 1 )
        The action (frostscythe) is usable at (0.00 + 1.31) with cost of 2 runes (have 6).
         - the action is ready before the current recommendation (at +1.31 vs. +17.45).
        List ( aoe ) called from ( Frost DK:default:39 ) would PASS at 1.31.
        active_enemies[3.00] >= 3
        frostscythe_prio #1 [Frost DK:default:6]; conditions = FAIL: set_bonus.tww3_rider_of_the_apocalypse_4pc[1.00] > 0 & ! ( talent.cleaving_strikes.enabled[true] & buff.remorseless_winter.up[true] )
         - value = 3: 4
         - this entry's criteria PASSES: ( buff.killing_machine.stack[1.00] = 2 | ( buff.killing_machine.up[true] & rune.current[6.00] >= 3 ) ) & active_enemies[3.00] >= variable.frostscythe_prio[3.00]
        Action chosen:  frostscythe at 1.31!

This is a snapshot that I just generated. It's hard to interpret, but this shows that I have 4pc, Cleaving Strikes is talented, and Remorseless Winter is active. This results in a requirement for 3 targets.

        frostscythe_prio #1 [Frost DK:default:6]; conditions = FAIL: set_bonus.tww3_rider_of_the_apocalypse_4pc[1.00] > 0 & ! ( talent.cleaving_strikes.enabled[true] & buff.remorseless_winter.up[true] )
         - value = 3: 4

In my snapshot, Frostscythe was selected because Killing Machine was up and I have 3+ Runes and 3 targets.

commented

The issue still persists with latest version, as soon as you hit Pillar of frost on 3 targets, Obliterate becomes recommended instead of Frostscythe.

commented

The issue still persists with latest version, as soon as you hit Pillar of frost on 3 targets, Obliterate becomes recommended instead of Frostscythe.

That is not what this ticket is about.

Frostscythe should trigger on 3 targets only when Remorseless Winter is active, but currently it is not used in this scenario.

Now it does.

commented

The issue still persists with latest version, as soon as you hit Pillar of frost on 3 targets, Obliterate becomes recommended instead of Frostscythe.

That is not what this ticket is about.

Frostscythe should trigger on 3 targets only when Remorseless Winter is active, but currently it is not used in this scenario.

Now it does.

still not working for me... i tried reinstall hekili but same problem, The only thing that changed is that Frostscythe appears in the queue after Pillar of Frost, but as soon as I press pillar of frost and Remorseless Winter is up, it disappears and Obliterate is shown again

commented

The issue still persists with latest version, as soon as you hit Pillar of frost on 3 targets, Obliterate becomes recommended instead of Frostscythe.

That is not what this ticket is about.

Frostscythe should trigger on 3 targets only when Remorseless Winter is active, but currently it is not used in this scenario.

Now it does.

still not working for me... i tried reinstall hekili but same problem, The only thing that changed is that Frostscythe appears in the queue after Pillar of Frost, but as soon as I press pillar of frost and Remorseless Winter is up, it disappears and Obliterate is shown again

Please get a proper snapshot during the time you think the recommendation is incorrect.

Instructions: https://github.com/Hekili/hekili/wiki/Report-An-Issue#how-do-i-get-a-snapshot

(and open a new ticket)

commented

The issue still persists with latest version, as soon as you hit Pillar of frost on 3 targets, Obliterate becomes recommended instead of Frostscythe.

That is not what this ticket is about.

Frostscythe should trigger on 3 targets only when Remorseless Winter is active, but currently it is not used in this scenario.

Now it does.

still not working for me... i tried reinstall hekili but same problem, The only thing that changed is that Frostscythe appears in the queue after Pillar of Frost, but as soon as I press pillar of frost and Remorseless Winter is up, it disappears and Obliterate is shown again

I just copy pasted the rotation into notepad and removed the mentions of the 4P Then you click import to load your "fixed" version

I deleted this:

# Frostscythe is equal at 3 targets, except with Rider 4pc which brings Obliterate higher at 3, unless cleaving strikes is up
## [Hekili] Revised to fix target count based on 4pc.
## actions+=/variable,name=frostscythe_prio,value=3+(1*(set_bonus.tww3_rider_of_the_apocalypse_4pc&!(talent.cleaving_strikes&buff.remorseless_winter.up)))
actions+=/variable,name=frostscythe_prio,value=4,value_else=3,condition=set_bonus.tww3_rider_of_the_apocalypse_4pc>0&!(talent.cleaving_strikes&buff.remorseless_winter.up)

the problem is when you delete it, he always use frostsycthe at 3 targets but you only want to use frostsycthe at 3 targets when remorseless winter buff is up

commented

The issue still persists with latest version, as soon as you hit Pillar of frost on 3 targets, Obliterate becomes recommended instead of Frostscythe.

That is not what this ticket is about.

Frostscythe should trigger on 3 targets only when Remorseless Winter is active, but currently it is not used in this scenario.

Now it does.

still not working for me... i tried reinstall hekili but same problem, The only thing that changed is that Frostscythe appears in the queue after Pillar of Frost, but as soon as I press pillar of frost and Remorseless Winter is up, it disappears and Obliterate is shown again

I just copy pasted the rotation into notepad and removed the mentions of the 4P
Then you click import to load your "fixed" version

I deleted this:

# Frostscythe is equal at 3 targets, except with Rider 4pc which brings Obliterate higher at 3, unless cleaving strikes is up
## [Hekili] Revised to fix target count based on 4pc.
## actions+=/variable,name=frostscythe_prio,value=3+(1*(set_bonus.tww3_rider_of_the_apocalypse_4pc&!(talent.cleaving_strikes&buff.remorseless_winter.up)))
actions+=/variable,name=frostscythe_prio,value=4,value_else=3,condition=set_bonus.tww3_rider_of_the_apocalypse_4pc>0&!(talent.cleaving_strikes&buff.remorseless_winter.up)
commented

The issue still persists with latest version, as soon as you hit Pillar of frost on 3 targets, Obliterate becomes recommended instead of Frostscythe.

That is not what this ticket is about.

Frostscythe should trigger on 3 targets only when Remorseless Winter is active, but currently it is not used in this scenario.

Now it does.

still not working for me... i tried reinstall hekili but same problem, The only thing that changed is that Frostscythe appears in the queue after Pillar of Frost, but as soon as I press pillar of frost and Remorseless Winter is up, it disappears and Obliterate is shown again

I just copy pasted the rotation into notepad and removed the mentions of the 4P Then you click import to load your "fixed" version
I deleted this:

# Frostscythe is equal at 3 targets, except with Rider 4pc which brings Obliterate higher at 3, unless cleaving strikes is up
## [Hekili] Revised to fix target count based on 4pc.
## actions+=/variable,name=frostscythe_prio,value=3+(1*(set_bonus.tww3_rider_of_the_apocalypse_4pc&!(talent.cleaving_strikes&buff.remorseless_winter.up)))
actions+=/variable,name=frostscythe_prio,value=4,value_else=3,condition=set_bonus.tww3_rider_of_the_apocalypse_4pc>0&!(talent.cleaving_strikes&buff.remorseless_winter.up)

the problem is when you delete it, he always use frostsycthe at 3 targets but you only want to use frostsycthe at 3 targets when remorseless winter buff is up

That's not the recommended prio I'm seeing from class discord (Archerus), Wowhead or Icy veins guides, you always want to use frostsycthe at 3 or more targets. in any scenario, 4p or not.

commented

The APL defines frostscythe target counts very clearly in the frostscythe_prio variable:

actions.variables+=/variable,name=frostscythe_prio,value=3+(1*(set_bonus.tww3_rider_of_the_apocalypse_4pc&!(talent.cleaving_strikes&buff.remorseless_winter.up)))
  • 3 default
  • 4 ONLY if 4-set rider AND you don't take cleaving strikes AND remorseless winter is NOT UP

Note this part: !(talent.cleaving_strikes&buff.remorseless_winter.up)

BOTH of those conditions MUST be false.

EVERY talent build on wowhead and icy-veins and in the Acherus FAQ takes cleaving strikes. That means frostscythe will ONLY be recommended at 3 targets, never 4.

commented

The APL defines frostscythe target counts very clearly in the frostscythe_prio variable:

actions.variables+=/variable,name=frostscythe_prio,value=3+(1*(set_bonus.tww3_rider_of_the_apocalypse_4pc&!(talent.cleaving_strikes&buff.remorseless_winter.up)))
  • 3 default
  • 4 ONLY if 4-set rider AND you don't take cleaving strikes AND remorseless winter is NOT UP

Note this part: !(talent.cleaving_strikes&buff.remorseless_winter.up)

BOTH of those conditions MUST be false.

EVERY talent build on wowhead and icy-veins and in the Acherus FAQ takes cleaving strikes. That means frostscythe will ONLY be recommended at 3 targets, never 4.

Cleaving Strikes is basically the default path for any build. No offense to the author of these lines but he clearly haven’t played the game.