Xuen not suggested when available
Closed this issue · 7 comments
Before You Begin
- I confirm I am using the latest version of the addon (outdated versions may have problems that were fixed on the newest release).
- I confirm I am playing on official Blizzard servers (not private servers).
- I checked for an existing, open ticket for this issue and was not able to find one.
- I have updated the issue title to clearly describe the problem.
- I am reporting an issue with the default specialization priority (not a custom or imported priority).
Specialization
Monk - Windwalker
Describe the Issue
I was fighting the boss before Dimensius and the addon was not suggesting Xuen, and it was making em hold for 20-30 sec before id use it myself.
How to Reproduce
1, Play Monk WW
2. Fight Boss
3. At some point Xuen is no longer suggested.
What is your information source?
Based on Class Guides (e.g., IcyVeins, Wowhead)
Snapshot (Link)
Raidbots Sim Report (Link)
No response
Additional Information
No response
Contact Information
plumpyhippo
Seems like the APLs differ. In simc, invoke_xuen_the_white_tiger has more conditions than just xuen_condition: (for Shado at least)
actions.cooldowns+=/invoke_xuen_the_white_tiger,target_if=max:target.time_to_die,if=(target.time_to_die>12|!talent.xuens_bond&target.time_to_die>8)&set_bonus.tww3_2pc&talent.celestial_conduit&cooldown.strike_of_the_windlord.remains<3&(chi>2&talent.ordered_elements|chi>5|chi>3&energy<50|energy<50&active_enemies=1|prev.tiger_palm&!talent.ordered_elements&time<5)|(!set_bonus.tww3_2pc|!talent.celestial_conduit|!fight_style.patchwerk)&(variable.xuen_condition&!fight_style.dungeonslice&!fight_style.dungeonroute|variable.xuen_dungeonslice_condition&fight_style.Dungeonslice|variable.xuen_dungeonroute_condition&fight_style.dungeonroute)
vs Hekili
actions.cooldowns+=/invoke_xuen_the_white_tiger,if=variable.xuen_condition
xuen_condition in simc:
(active_enemies=1&(time<10|talent.xuens_bond&talent.celestial_conduit)|active_enemies>1)
&cooldown.storm_earth_and_fire.ready
&(target.time_to_die>14&)
&(active_enemies>2|debuff.acclamation.up|!talent.ordered_elements&time<5)
&(chi>2&talent.ordered_elements|chi>5|chi>3&energy<50|energy<50&active_enemies=1|prev.tiger_palm&!talent.ordered_elements&time<5)
|fight_remains<30
|!boss&talent.celestial_conduit&target.time_to_die>14
xuen_condition in Hek (from snapshot):
( active_enemies[1.00] = 1 & ( time[378.31] < 10 | talent.xuens_bond.enabled[false] & talent.celestial_conduit.enabled[false] ) | active_enemies[1.00] > 1 )
& cooldown.storm_earth_and_fire.ready[true]
& ( target.time_to_die[80.99] > 14 )
& ( active_enemies[1.00] > 2 | debuff.acclamation.up[true] | ! talent.ordered_elements.enabled[true] & time[378.31] < 5 )
& ( chi.current[6.00] > 2 & talent.ordered_elements.enabled[true] | chi.current[6.00] > 5 | chi.current[6.00] > 3 & energy.current[65.12] < 50 | energy.current[65.12] < 50 & active_enemies[1.00] = 1 | prev.tiger_palm[false] & ! talent.ordered_elements.enabled[true] & time[378.31] < 5 ) |
boss[true] & fight_remains[80.69] < 30
which is the same, but missing part of the APL:
(target.time_to_die>12|!talent.xuens_bond&target.time_to_die>8)
&set_bonus.tww3_2pc
&talent.celestial_conduit
&cooldown.strike_of_the_windlord.remains<3
&(chi>2&talent.ordered_elements|chi>5|chi>3&energy<50|energy<50&active_enemies=1|prev.tiger_palm&!talent.ordered_elements&time<5)
|(!set_bonus.tww3_2pc|!talent.celestial_conduit|!fight_style.patchwerk)
&(variable.xuen_condition&!fight_style.dungeonslice&!fight_style.dungeonroute|variable.xuen_dungeonslice_condition&fight_style.Dungeonslice|variable.xuen_dungeonroute_condition&fight_style.dungeonroute)
it'll never be suggested outside of opener & finisher.
Appears to be the same issue as here:
The default Hekili WW APL has not been synced since Mar 22: f1e6dda
The current Simc APL is here: https://github.com/simulationcraft/simc/blob/thewarwithin/ActionPriorityLists/default/monk_windwalker.simc
You can manually import the new Simc profile, but you will need to manually clean up the results.
The default Hekili WW APL has not been synced since Mar 22: f1e6dda
The current Simc APL is here: https://github.com/simulationcraft/simc/blob/thewarwithin/ActionPriorityLists/default/monk_windwalker.simc
You can manually import the new Simc profile, but you will need to manually clean up the results.
Not a great idea simc -Hekili is not a 1-1 translation
The default Hekili WW APL has not been synced since Mar 22: f1e6dda
The current Simc APL is here: https://github.com/simulationcraft/simc/blob/thewarwithin/ActionPriorityLists/default/monk_windwalker.simc
You can manually import the new Simc profile, but you will need to manually clean up the results.Not a great idea simc -Hekili is not a 1-1 translation
Hence the "you will need to manually clean up the results." The default Hekili APLs are based off the Simc ones but, as you say, they are not 1:1 compatible. Hekili will try to do some automated fixing up when you import as well, but it will not get everything.
To wit, I have imported the current Simc APL into Hekili to resolve this issue and once fixed up, CDs are being recommended properly. It is an option for those interested until the maintainers are able to do an official import themselves.
You are better off if you think you have done it correctly submitting a PR with the changes.
Telling people to import things when they don’t understand what they are doing is just going to cause a mess for most people.
