Hekili Priority Helper

Hekili Priority Helper

53M Downloads

[REC] Frost DK - Frostbane not being suggested for AOE scenarios

Closed this issue ยท 4 comments

commented

Before You Begin

  • I confirm I am using the latest version of the addon (outdated versions may have problems that were fixed on the newest release).
  • I confirm I am playing on official Blizzard servers (not private servers).
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I have updated the issue title to clearly describe the problem.
  • I am reporting an issue with the default specialization priority (not a custom or imported priority).

Specialization

DK - Frost

Describe the Issue

For my Frost DK, I expect the addon to recommend Frostbane in AOE scenarios when I have 5 stacks of Razorice on a target.
However, addon doesn't recommend Frostbane in AOE, but sometimes in ST scenarios.

Last time it worked on v11.2.0-1.0.0n
Since then it's broken.

Screenshot showing that we have 5 Razorice stacks and it is an AOE scenario:
https://imgbox.com/Igmen1BB

Snapshot from v11.2.0-1.0.0n where it works well enough:
https://pastebin.com/ZGpQ9vBr

Screenshot from v11.2.0-1.0.0n:
https://imgbox.com/IeBWFyjt

How to Reproduce

  1. Enter game as a Frost DK
  2. Take this build: CsPAclESCN5uIs3wGGVadXqL3ZAmZGzYMGGmZmZmhZmRzMmZYmZGMzwMzMzMzMAAAAAAAAAAAAsZ2MMwAzmGaYDjZGzMgxA
  3. Go to 5 target dummies
  4. Build up 5 stacks of Razorice + Frostbane proc
  5. See recommendations

What is your information source?

Based on my in-game experience and intuition

Snapshot (Link)

https://pastebin.com/BpP9jiUN

Raidbots Sim Report (Link)

https://www.raidbots.com/simbot/report/9zyc7kBUahVvUYMLXN3R9H

Additional Information

To see a Frostbane being used in raidbots sim - expand Frost Strike ability

Image

Contact Information

Discord: di.n.ki

commented

hekili apl is missing this entry to check for frostbane in aoe:

actions.aoe+=/frost_strike,target_if=max:(talent.shattering_blade&debuff.razorice.react=5),if=debuff.razorice.react=5&buff.frostbane.react

https://github.com/simulationcraft/simc/blob/thewarwithin/profiles/TWW3/TWW3_Death_Knight_Frost.simc#L53

it has been commented out by @Hekili, but you can try to test it by setting the conditions to this (not tested):

actions.aoe+=/frost_strike,cycle_targets=1,if=debuff.razorice.stack=5&(talent.shattering_blade&active_enemies<5&!variable.rp_pooling&!talent.frostbane|buff.frostbane.up)
commented

hekili apl is missing this entry to check for frostbane in aoe:

actions.aoe+=/frost_strike,target_if=max:(talent.shattering_blade&debuff.razorice.react=5),if=debuff.razorice.react=5&buff.frostbane.react

https://github.com/simulationcraft/simc/blob/thewarwithin/profiles/TWW3/TWW3_Death_Knight_Frost.simc#L53

it has been commented out by @Hekili, but you can try to test it by setting the conditions to this (not tested):

actions.aoe+=/frost_strike,cycle_targets=1,if=debuff.razorice.stack=5&(talent.shattering_blade&active_enemies<5&!variable.rp_pooling&!talent.frostbane|buff.frostbane.up)

I can confirm that Frostbane is being suggested with such conditions (not sure if optimal but it definitely does it)

commented

I have that line added as a part of my PR here: #5160

You could try using that branch and see if the behavior is resolved.

commented

I believe this can be closed as resolved.