Hekili Priority Helper

Hekili Priority Helper

Addons
53M Downloads

state.hero_tree is none in Timewalking raid

Closed this issue ยท 1 comments

commented

Before You Begin

  • I confirm I am using the latest version of the addon (outdated versions may have problems that were fixed on the newest release).
  • I confirm I am playing on official Blizzard servers (not private servers).
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I have updated the issue title to clearly describe the problem.
  • I am reporting an issue with the default specialization priority (not a custom or imported priority).

Specialization

DK - Blood

Describe the Issue

When running timewalking Ulduar in Blood DK, Hekeli doesn't really recommend anything except blood boil and death and decay. It doesn't recommend anything else.

Blood APL extensively checks for hero_tree variable, I guess that's why it's not recommending.

From the snapshot:

Blood; Primary - death_and_decay(5.15)
build: v11.2.0-1.0.0r
level: 80 (30)
class: DEATHKNIGHT
spec: blood
hero tree: none

A bit of debugging, I guess this is the culprit:

state.hero_tree = setmetatable( {}, {
    __index = function( t, k )

        if state.level < 71 then
            return false
        end

        if k == "current" then
            return ns.getActiveHeroTreeName()
        end

        return ns.getActiveHeroTreeName() == k
    end
} )

How to Reproduce

  1. Take a Blood DK into Ulduar TW
  2. See recommendations

What is your information source?

Based on my in-game experience and intuition

Snapshot (Link)

https://pastebin.com/Pn7swHx5

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

commented

Can maybe do something with UnitEffectiveLevel("player") vs UnitLevel("player") here?