[REC] Devastation Evoker - Engulf condition mis-detects Fire Breath level
Closed this issue · 3 comments
Before You Begin
- I confirm I am using the latest version of the addon (outdated versions may have problems that were fixed on the newest release).
- I confirm I am playing on official Blizzard servers (not private servers).
- I checked for an existing, open ticket for this issue and was not able to find one.
- I have updated the issue title to clearly describe the problem.
- I am reporting an issue with the default specialization priority (not a custom or imported priority).
Specialization
Evoker - Devastation
Describe the Issue
Engulf condition mis-detects Fire Breath level due to DoT refresh behavior with Causality + 4-set opener
Description:
The current condition for recommending Engulf with Scorching Embers is:
( !talent.scorching_embers.enabled | dot.fire_breath_damage.duration <= 6 )
This check assumes that only a level-4 Fire Breath applies a 6-second DoT, and therefore Engulf should only be recommended immediately after such a cast.
Issue:
With the 11.2 patch + 4-set opener, the rotation involves casting level-1 Fire Breaths inside Dragonrage to trigger cooldown reduction via Causality.
A level-1 Fire Breath normally applies a 24-second DoT.
In earlier patches, the cooldown on Fire Breath (30s) meant that a new Fire Breath would not come off cooldown until the original DoT had expired.
In 11.2, however, Causality reduces the cooldown such that a new Fire Breath becomes available while the original level-1 DoT still has 2–3 seconds remaining.
Casting this new Fire Breath refreshes the DoT: the remaining 2–3 seconds are added to the 6 seconds from the new level-4 Fire Breath (if cast at full charge), resulting in a DoT duration of ~8–9 seconds on the target.
At this point, the API sees dot.fire_breath_damage.duration = 8–9, which fails the <= 6 check, even though the most recent Fire Breath was in fact a level-4 cast. As a result, Hekili does not recommend Engulf when it should.
Expected Behavior:
Engulf should be recommended after a level-4 Fire Breath, even if the DoT duration on the target is >6 due to refresh mechanics.
Actual Behavior:
Engulf is not recommended, because the condition falsely interprets a refreshed level-4 Fire Breath as a non-level-4 based on DoT duration alone.
Proposed Fix:
Relax the duration check slightly, for example:
( !talent.scorching_embers.enabled | dot.fire_breath_damage.duration <= 11 )
A level-3 Fire Breath applies a 12s DoT, so <= 11 safely excludes level-3/2/1 casts.
This adjustment accounts for refresh mechanics where a level-4 Fire Breath DoT can display as 7–9s due to residual duration carryover from a previous DoT.
This ensures Engulf will be recommended correctly in the 4-set opener and other high-haste scenarios.
How to Reproduce
Follow the suggested rotation perfectly and you should notice that when you should get the 3rd engulf in the fight (when you come right out of the dragonrage duration) it suggests you to cast disintegerate instead of engulf even if you just casted a level-4 fire breath.
What is your information source?
Based on my in-game experience and intuition
Snapshot (Link)
Raidbots Sim Report (Link)
https://www.dpswow.com/report?id=e83099b8-a41d-4209-a10d-e79fa554ad56
Additional Information
No response
Contact Information
No response
-
The snapshot you provided isn't showing Disintegrate or Engulf. I'll need the snapshot of when you are experiencing the issue (i.e., you just used Fire Breath r4, Dragonrage is over, but Disintegrate is recommended rather than Engulf).
-
Your sim report seems to do the same as the addon, unless I've misunderstood something.
Your last Fire Breath r4 during Dragonrage gets Engulfed (after a Shattering Star). Your first Fire Breath after Dragonrage is lower-ranked and followed by Disintegrate.
My apologies - I meant to say engulf no.3. In real game one would already be out of dragonrage but in the sim report it seems to believe the player should still have dragon rage. Nevertheless, I meant to say the engulf no.3 should be casted after fireabreath no.3, and I believe the rec here should not be impacted by whether or not the player still has dragonrage.
https://pastebin.com/gEVjCv9s
Please find attached the new snapshot above - it was captured when the 3rd firebreath is about to be recommended. It should recommend FB -> Shattering Star -> Engulf but suggested FB -> Shattering Star -> Disintegrate. The reason why engulf was not recommended was because the residual 1.8s of the 2nd firebreath cast (level-1) was refreshed by the 3rd firebreath cast (level-4) by an additional 6 seconds.
