Hekili Priority Helper

Hekili Priority Helper

53M Downloads

[REC] ⚠️ DK soul_reaper related issues

Closed this issue · 4 comments

commented

Before You Begin

  • I confirm I am using the latest version of the addon (outdated versions may have problems that were fixed on the newest release).
  • I confirm I am playing on official Blizzard servers (not private servers).
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I have updated the issue title to clearly describe the problem.
  • I am reporting an issue with the default specialization priority (not a custom or imported priority).

Specialization

DK - Frost

Describe the Issue

soul_reaper related issues

How to Reproduce

  1. It will never recommend soul reaper using frost

What is your information source?

APL Conditions - I found a possible typo or mistake

Snapshot (Link)

Since I already updated my Hekili pripority, I wont update a snapshot

Raidbots Sim Report (Link)

Since I already updated my Hekili pripority, I wont update a raidbots

Additional Information

  1. Typo: talent.reaper_of_souls buff.reaper_of_souls should be replaced by talent.soul_reaper buff.soul_reaper
Image
  1. No longer a buff but debuff: buff.soul_reaper is from old patches; now it is a debuff, should be debuff.soul_reaper
  2. Logic change: Even if you change it to : talent.soul_reaper.enabled & debuff.soul_reaper.up & buff.killing_machine.stack < 2, it will never be triggled if you do not use soul reaper first since there wont be a debuff of soul reaper.

My suggestion is: talent.soul_reaper.enabled & (fight_remains>5 & target.time_to_pct_35<5 & target.time_to_die>5 & rune>2) & buff.killing_machine.stack < 2; you can double check and update it.

Contact Information

No response

commented

What you are suggesting has nothing to do with the issue you are experiencing. Since you have stated you won't provide a snapshot or sim link, we will be unable to assist without that diagnostic info.

Be sure to read the names again .. reaper_of_souls and soul_reaper are 2 entirely different things. One is a spell, one is a hero talent which affects that spell.

Reaper of Souls is applied by your Reaper's Mark as a Deathbringer Hero tree build.

When I run a correct soul reaper build, it's like the 5th recommendation after starting combat.

Image Image
commented
Image
commented

I know reaper_of_souls is the hero talent there. So you mean the current priporty will never use soul reaper if the hero talent reaper_of_souls is not enable? Therefore never enable soul reaper if you not enable hero talent reaper_of_souls?

commented

That's a question for the Death Knight discord, or perhaps in the Frost DK written guides. If you had provided a raidbots sim link as per ticket instructions, that would've shown whether or not you are supposed to use it with whatever talents you had selected.