Before Shadowlands I added a line,

talent.earth_shield.enabled & buff.earth_shield.down

and turned off the lightning shield buff, but now it's not working. It doesn't show up on the primary bar, I'm not well versed in this so could anyone help me?

Seems to work with elemental when the precombat is pretty bare.. might be to do with what already is there for enhancement.

You'd need to post a snapshot for me to see the decision-making, but if your entry for Earth Shield is at the end of the priority, after a spell that would cause combat to begin, it's not going to be recommended.

Basically I like to have it so if I choose the Earth Shield talent it appears priority to recast if it's down, I put the,

talent.earth_shield.enabled & buff.earth_shield.down

line in precombat and default rotation, so in pvp it'll always remind me to recast if it's fallen down. I also edit -just- the precombat lightning shield conditions so it doesn't appear if I choose the earth shield talent.

It works for elemental but for some reason the same code doesn't work for enhancement.

Elemental Precombat which works

Elemental default rotation which works

Enhancement precombat doesn't work

Enhancement default rotation doesn't work

Same conditions but different results. Probably something really simple, again I'm really not well versed in to this.

Thanks :)

Snapshot, not screenshots. Refer back to the instructions in a new ticket.

Earth Shield's spell ID changed for Enhancement in Shadowlands. I've updated to match it, which will be in the next release.

At that time, something like this should work:

It's worth noting, that you don't need to check talent.earth_shield.enabled to use Earth Shield -- if you don't have the talent, the addon knows you can't use it and rules it out internally.