Don't show GCD on abilities that are off the GCD

Question

Don't show GCD on abilities that are off the GCD

cremor opened this issue 4 years ago · 11 comments

cremor commented 4 years ago

Abilities that are always off the GCD like Shield of the Righteous from the Protection Paladin shouldn't show the GCD on the icon.

Hekili · Answer 1 · 2020-12-11T00:56:50.000Z

This may be addressed in 1.0.23.

Hekili · Answer 2 · 2020-12-11T15:02:08.000Z

The bar button would not show a spiral when the addon is delaying SotR to wait for the buff to wear off. But I'll check it out.

cremor · Answer 3 · 2020-12-11T13:50:54.000Z

I've just tested 1.0.23. The main icon still shows the GCD for Shield of the Righteous. The queue icons behaves a bit weird. Most of the time it doesn't show the GCD, but sometimes it does. I couldn't figure out when.

I don't really care about the queue icon, but fixing it for the main icon would be great. So please re-open this issue.

Here is a snapshot. I took it during the GCD while Shield of the Righteous was on the main icon. https://pastebin.com/r2XM4CuH
And here the general issue information: https://pastebin.com/a1x2ukQk

Hekili · Answer 4 · 2020-12-11T14:05:32.000Z

The spiral isn't always the GCD; it can also be the delay if you're waiting to use it (i.e., daisy-chaining or waiting to push right as the buff falls off).

cremor · Answer 5 · 2020-12-11T14:24:11.000Z

Sure, but in my tests it was always shown when I used an ability. So I'm quite sure that it was the GCD.
Also, the bar button didn't show the spiral, only the icon of Hekili.

Hekili · Answer 6 · 2021-03-09T03:26:39.000Z

This appears to be resolved.

cremor · Answer 7 · 2021-03-10T17:11:19.000Z

Character data: https://pastebin.com/yjpy8tbS
Snapshot with 5 HP and everything off CD: https://pastebin.com/gNvYttP1
Snapshot with same conditions but during GCD (I hope I got it): https://pastebin.com/Ne3GEpJn

Hekili · Answer 8 · 2021-03-10T17:24:18.000Z

You have your addon configured to sync with the GCD, so it does.

cremor · Answer 9 · 2021-03-10T17:33:59.000Z

Oh, wow, sorry. I didn't even remember that that option exists. And I had to read its descripton 3 times now to understand what it actually does. I always thought that it only affects the recommendation itself, not the cooldown swirl on it.
Thanks!

cremor · Answer 10 · 2021-03-10T16:56:30.000Z

@Hekili I can not confirm that this is fixed in v9.0.5-1.0-beta1. To be more specific: It seems to be fixed for the queue icons, but not for the main icon.

Repro steps for a Prot Paladin:

Build 5 holy power so that Shield of the Righteous is shown on the main icon.
Use any ability.
The main icon will show the GCD spiral on Shield of the Righteous.

Please reopen.

Hekili · Answer 11 · 2021-03-10T16:57:05.000Z

Provide a fresh snapshot of that, please.

Share to