Echoin Reprimand + Slice n Dice. [ROGUE]
endisnear1010 opened this issue · 21 comments
Hekili sometimes tries to spend the Animacharged combopoint produced by echoing reprimand on Slice n dice. The animacharged combopoint only works for damaging finishers.
I can +1 this. Hekili tries to spend the Animacharged combo point on SnD to get a 7 combo point finisher, but it only works on damaging finishers. Not the biggest issue, but would be a great QoL fix regardless :)
I'll see what I can do about generating a snapshot, since this bug appears at random times, during random encounters which makes it pretty hard to replicate. I'll have to raid and run some dungeons to do further testing.
Nothing happens at random times. You'd likely be able to replicate this issue on a target dummy.
It's in the ticket instructions, as noted in my first response.
BEFORE SUBMITTING AN ISSUE:
-
Check to see if you are using the latest version of the addon. If there is a newer alpha/beta/release version, see if your problem exists with the new version.
-
Check to see if someone else has already opened an issue report here. Please don't submit repeat reports.
Describe the Bug/Issue
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
- Go to '...'
- Click on '....'
- Scroll down to '....'
- See error
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
WHEN SUBMITTING AN ISSUE:
Please provide the following information. Leaving it out may result in your ticket being ignored (because I won't have the information needed to explore your report).
- The information from the Issue Reporting tab ( /hekili > Issue Reporting ). This provides your talent and gear information. You can paste it to pastebin.com and provide a link here.
PUT ISSUE REPORT LINK HERE:
- If reporting a disagreement with the addon's recommendations, please take a snapshot when you observe the issue and provide the snapshot. This is not a screenshot. A snapshot can be generated by binding the Pause feature on the Toggles tab. When you press Pause, a snapshot of how the addon decided on its CURRENT recommendations is generated and saved to the Snapshots tab. Copy and paste this to pastebin.com and provide the link here.
PUT SNAPSHOT LINK HERE:
- If reporting an error (i.e., the addon freezes and/or disables itself), please install the BugSack and BugGrabber addons as they will enable you to paste the exact error message, with detail that will help me identify where the code error is located. You can paste the error information here or use pastebin.com for that as well.
PUT ERROR MESSAGE(S) HERE:
i hope this is right https://pastebin.com/CvHExRP8
In this particular situation - it suggests to apply SnD on the 2nd animacharged combo point, but after using sinister strike, it goes back to the default behavior of suggesting SnD on 6 combo points,
I need a snapshot where Slice and Dice is recommended when you have the animacharged # of combo points. The snapshot provided does not do that.
a screenshot is missing many many many informations that are NEEDED to find the issue. That means a screenshot is completely worthless. you need to post a SNAPSHOT when the issue happens so it can be looked after.
Sorry am new here dont really know the difference between a snapshot and a screenshot. will check it out
I was looking into this from a code point of view and after discussing with Hekili we concluded that if the Slice n Dice logic is to be changed then it would actually end up in DPS loss.
Sims ran by Hekili;
Although it might feel strange to cast a non damage finisher when animacharged it follows the simulationcraft APL and results in the best DPS possible.
@aquos757 I noticed your last post you deleted and can understand that it may be confusing somewhat.
We simmed using the simulationcraft APL, (the one the addon uses), and a version with Slice n Dice not being used whilst animacharged.
The sim shows that it doesn't matter that you don't get the 7 CP duration, you'll still end up with better DPS in all cases. Hope that explains it better.
It should only be changed if it actually increases our DPS, which it doesn't as the sims show.