HeroLib and Titan init with TSM interaction issue.

This occurs when logging in and during addon loadin. if I disable TSM this does not occur.

I also reported this to the TSM folk.

LUA error text:

Date: 2019-01-20 07:27:39
ID: 1
Error occured in: Global
Count: 1
Message: ...\HeroLib\Lib\LibUIDropDownMenu\LibUIDropDownMenu.lua line 110:
attempt to index field '?' (a nil value)
Debug:
...ce\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:613:
...ce\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:575
[C]: ?
...\HeroLib\Lib\LibUIDropDownMenu\LibUIDropDownMenu.lua:110: L_UIDropDownMenu_Initialize()
Titan\TitanUtils.lua:1569:
Titan\TitanUtils.lua:1557
Titan\TitanUtils.lua:1664: TitanPanelDisplayRightClickMenu_Toggle()
Titan\TitanPanel.lua:581: TitanPanelBarButton_OnClick()
TitanReputation\TitanReputation.lua:190: TitanPanelReputationButton_OnLoad()
[string ":OnLoad"]:1:
[string ":OnLoad"]:1
Locals:
errMsg = "...\HeroLib\Lib\LibUIDropDownMenu\LibUIDropDownMenu.lua:110: attempt to index field '?' (a nil value)"
errorTime = 2022372.615783
tsmErrMsg = nil
oldModule = nil
private =

AddOns:
Swatter, v8.0.6162 (SwimmingSeadragon)
AAPCore, v8.1046
Ace3, v
ACP, vr259
AllTheThings, v1.8.2b
Altoholic, vr190
AskMrRobot, v71
AtlasLoot, vv8.09.00
AtlasLootBattleforAzeroth, vv8.09.00
AtlasLootBurningCrusade, vv8.09.00
AtlasLootCataclysm, vv8.09.00
AtlasLootClassic, vv8.09.00
AtlasLootLegion, vv8.09.00
AtlasLootMistsofPandaria, vv8.09.00
AtlasLootWarlordsofDraenor, vv8.09.00
AtlasLootWrathoftheLichKing, vv8.09.00
AucAdvanced, v8.0.6122 (SwimmingSeadragon)
AucFilterBasic, v8.0.6149 (SwimmingSeadragon)
AucStatHistogram, v8.0.6151 (SwimmingSeadragon)
AucStatiLevel, v8.0.6155 (SwimmingSeadragon)
AucStatPurchased, v8.0.6152 (SwimmingSeadragon)
AucStatSimple, v8.0.6153 (SwimmingSeadragon)
AucStatStdDev, v8.0.6154 (SwimmingSeadragon)
AucUtilFixAH, v8.0.6156 (SwimmingSeadragon)
Auctionator, v8.1.0
AutoRepair, v
AzeritePowerWeights, v8.1.7
AzerothAutoPilot, v
BadNomi, v0.8.4
BagBrother, v
Bagnon, v8.0.7
BarrelsOEasy, v1.1.11
BattlePetBreedID, vr185
BattlePetCount, v1.8.16
BeanCounter, v8.0.6157 (SwimmingSeadragon)
BigWigs, vv123
BonusRollPreview, v80000.46-Release
BtWQuests, v1.34
BtWQuestsBattleForAzeroth, v22
BtWQuestsBattleForAzerothPrologue, v10
BtWQuestsClassic, v4
BtWQuestsLegion, v17
CanIMogIt, v8.0.0v1.13
DataStore, vr65
DataStoreAgenda, vr29
DataStoreAuctions, vr50
DataStoreCharacters, vr43
DataStoreContainers, vr59
DataStoreCrafts, vr82
DataStoreCurrencies, vr38
DataStoreGarrisons, vr24
DataStoreInventory, vr53
DataStoreMails, vr52
DataStorePets, vr44
DataStoreQuests, vr46
DataStoreReputations, vr43
DataStoreSpells, vr32
DataStoreStats, vr31
DataStoreTalents, vr61
DBMCore, v8.1.2
DBMDefaultSkin, v
DBMStatusBarTimers, v
Decursive, v2.7.6.2
DraenorTreasures, v8.0.1.27144
DugisGuideViewerZ, v5.100
FishingAce, v0.8.9
FishingBuddy, v1.9.25p1
GarrisonCommanderBroker, v3.0.1 1.1.0
GatherMate2, v1.43.4
Grail, v099
GrailQuestsenUS, v27178
GTFO, v4.46.12
GupPet, v8.0.1.05
HandyNotes, vv1.5.3
HandyNotesArgus, vv0.12
HandyNotesBattleForAzerothAchievments, vv7
HandyNotesBattleForAzerothTreasures, v1
HandyNotesBrokenShore, vv1.30
HandyNotesDraenorTreasures, v1.21
HandyNotesDungeonLocations, v1.45
HandyNotesHallowsEnd, vv1.4.3
HandyNotesHigherLearning, v8.0.0.0
HandyNotesLegionClassOrderHalls, vv1.30
HandyNotesLegionRaresTreasures, v1.1
HandyNotesLegionTreasures, v1
HandyNotesLunarFestival, vv1.5
HandyNotesSummerFestival, vv1.5
HandyNotesTimelessIsleChests, v1.21
HandyNotesTreasureHunter, v1
HandyNotesUniversalExplorer, v8.0.1.2
HandyNotesWarfrontRares, v0.5.0
HandyNotesWarfrontTreasures, v1
HandyNotesWellRead, v8.0.0.0
HealBot, v8.1.0.1
HeroCache, v8.0.1.09
HeroLib, v8.0.1.09
HeroRotation, v8.0.1.09
LibBabbleBoss30, v
LibBabbleFaction30, v
LibDBIcon10, v
LibDialog10, vr93
LibQTip10, v8.0.1.1
LibSharedMedia30, v3.0-104
LibTabbedFrame10, v0.3
LibTextDump10, v8.1.0.1
LookingForGroup, vr1823
LookingForGroupBindings, vr1823
LookingForGroupBroker, vr1823
LookingForGroupEvent, vr1823
LookingForGroupHook, vr1823
LookingForGroupIcon, vr1823
LookingForGroupSF, vr1823
LootAppraiser, vv1.9.3
MasterPlanA, vA
MinimapButtonFrame, v3.1.10h
MinimapButtonFrameSkinPack, v3.0.1b
MogIt, v3.8.11
OmniCC, v8.1.1
Outfitter, v5.22.1
Overachiever, v1.0.5
OverachieverCache, v1.0.5
Pawn, v2.2.34
PetBattleTeams, v3.3.11
PetTracker, v8.0.6
PetTrackerBreeds, v8.0.6
PetTrackerSwitcher, v8.0.6
PetTrackerUpgrades, v8.0.6
Postal, vv3.6.0
Prat30, vr1195
Prat30Libraries, v
QuestCompletist, v109.20
RareScanner, v5.3.1
Rarity, v1.0 (r681-release)
RarityOptions, v
Rematch, v4.9.4
Routes, vv1.6.0
SilverDragon, vv4.0.13
SilverDragonBattleForAzeroth, vv4.0.13
SilverDragonBurningCrusade, vv4.0.13
SilverDragonCataclysm, vv4.0.13
SilverDragonLegion, vv4.0.13
SilverDragonMists, vv4.0.13
SilverDragonVanilla, vv4.0.13
SilverDragonWarlords, vv4.0.13
SilverDragonWrath, vv4.0.13
Simulationcraft, v1.10.10
Skada, v1.7.5
SlideBar, v8.0.6160 (SwimmingSeadragon)
SpellFlashCore, v2.1.8
Stubby, v8.0.6161 (SwimmingSeadragon)
TheUndermineJournal, v5.4.20190119
Titan, v5.16.1.80100
TitanBag, v5.16.1.80100
TitanClock, v5.16.1.80100
TitanCurrenciesMulti, v6.3
TitanCurrency, v8.1
TitanGold, v5.16.1.80100
TitanGuild, v8.0.0.0
TitanLocation, v5.16.1.80100
TitanLootType, v5.16.1.80100
TitanPerformance, v5.16.1.80100
TitanRepair, v5.16.1.80100
TitanReputation, v3.9.5
TomTom, vv80100-1.0.0-beta
TradeSkillMaster, vv4.6.13
BlizRuntimeLib_enUS v8.1.0.80100
(ck=125e)

Just FYI, since I ran into this as well -- the best solution is to drop LibUIDropDownMenu or similar libraries. UIDropDownMenu no longer causes taints as of 8.0.1 or 8.1.

Thanks @Hekili for the comment, I will look into dropping LibUIDropDownMenu. 👍

I did removed it in e09628e
Although for now I'll keep it on a separate branch to do more testing, will let you know when it's merged into master.

Merged in master in 9ce8141