HeroLib

HeroLib

Addons
2M Downloads

[Demonology] SoulShards() sometimes returns a decimal

Zeldern opened this issue ยท 1 comments

commented

Sometimes demonology returns a decimal number e.g. 1.1 or 2.1 for shards which effects the next spell shown in the rotation.

I noticed that within the wow interface files specifically ShardBar.lua they have the following where they use math.floor to ensure soulshards are not decimal for both demonology and affliction. Shouldn't we also be using this for our soulshards function?

local shardPower = WarlockPowerBar_UnitPower(self:GetUnit());

-- Bug ID: 496542: Destruction is supposed to show partial soulshards, but Affliction and Demonology should only show full ones.
if GetSpecialization() ~= SPEC_WARLOCK_DESTRUCTION then
    shardPower = math.floor(shardPower);
end```
commented

Added flooring of shard count to the SoulShardsP override function for Demonology Warlocks within Hero Rotation. Commit: herotc/hero-rotation@58e32d6