HeroRotation

HeroRotation

5M Downloads

[Bug]: [Hunter] Pet can sometimes be treated as alive, even when dead

lab1702 opened this issue ยท 8 comments

commented

What version of HeroRotation are you using?

10.2.0.32

What version of HeroLib are you using?

10.2.0.17

What version of HeroDBC are you using?

10.2.0.04

What is the issue?

The most recent change to hunter pet status detection seems to have made things worse. When the pet is dead, I've had it show regular abilities as if the pet was alive, or the pet mend suggestion. Will see if there are specific sequences of events that always replicates this.

Icon Behavior

Icon does NOT disappear

commented

Couple hours of testing in dungeon, outdoors and tank dummy, did not break at all. The old problem of logging out mounted is also still fixed.

commented

It looks like it was possible for the pet's GUID in the Hunter table to be set to Hati's GUID, rather than your primary pet's GUID. I've made a change to delay the setting of pet status and GUID by 1 second (from completion of the cast) when casting Revive Pet. This change is in commit a3e9127

Please let me know if this fixes your issue or if it continues to occur.

commented

Spoke a tiny bit too soon.. had it think pet was summoned when it wasn't after a death in an instance.

commented

Your death or the pet's death?

commented

That time it was just my death.

commented

I made another tweak to try to catch the edge cases. This is in commit feb36cf

commented

Great! I'm going to close the issue, then. Please let us know if you run into any other issues.

commented

I think this last fix took care of the last issue, have not had it happen since last update in instances or outside.